59: Update WhatsApp supported version annotation to latest version #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Angelina-C
requested review from
TeusSloot,
Carly-1,
isellis,
Marcel-NFI,
rdvdijk,
eoudsen and
btimbermont
rdvdijk
approved these changes
Jan 16, 2025
RELEASE_NOTES
Outdated
| @@ -1,3 +1,7 @@ | |||
| Version 2.4.0 | |||
| ------------- | |||
| 59. WhatsApp: update supported_version annotation to 2.24.23.78 | |||
There was a problem hiding this comment.
It does look like a little bit more happened than just updating the version annotation. Should we add something in the release notes about the updated WhatsApp actions?
|
|
||
| sleep(0.5) | ||
| self.driver.find_element(by=By.CLASS_NAME, value="android.widget.ImageView").click() | ||
| if self.is_present('//android.widget.LinearLayout[@content-desc="Gallery"]'): |
There was a problem hiding this comment.
Maybe add a comment above each of these two cases to explain a bit more?
E.g., what is the first case, when does it occur, and what is the second? I find it hard to understand by just looking at the XPath expressions.
Alternatively, we could extract two methods with meaningful names for each case.
…moving participants from group, and opening view once photos
btimbermont
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.