[lodestar]: add extraArgs and bump version (#126)

* feat: add args to startup command

* feat: remove lodestar flag

* feat: add config for metrics and extra arguments to lodestar

* feat: bump lodestar version

* feat: add serviceName to lodestar sts

* docs: update lodestar readme

* feat: bump lodestar chart version

* docs: update lodestar readme

* docs: update README

* feat: update maintainers

* feat: update codeowners

.github/CODEOWNERS

@@ -1,9 +1,13 @@
-# See https://github.com/scottrigby/prometheus-helm-charts/issues/12
-# https://docs.github.com/en/github/creating-cloning-and-archiving-repositories/about-code-owners
-# https://docs.github.com/en/github/creating-cloning-and-archiving-repositories/about-code-owners#codeowners-syntax
+# See <https://github.com/scottrigby/prometheus-helm-charts/issues/12>
+
+# <https://docs.github.com/en/github/creating-cloning-and-archiving-repositories/about-code-owners>
+
+# <https://docs.github.com/en/github/creating-cloning-and-archiving-repositories/about-code-owners#codeowners-syntax>
+
+# The repo admins team will be the default owners for everything in the repo
+
+# Unless a later match takes precedence, they will be requested for review when someone opens a pull request
 
-# The repo admins team will be the default owners for everything in the repo.
-# Unless a later match takes precedence, they will be requested for review when someone opens a pull request.
 * @NethermindEth/angkor-validator-operators
 
 /.github/workflows/ @NethermindEth/angkor-validator-operators @AntiD2ta @aivarasko @matilote
@@ -18,14 +22,15 @@
 /charts/juno-node/ @gehlotanish @Manjeet-Nethermind
 /charts/kong/ @gehlotanish @Manjeet-Nethermind
 /charts/kube-prometheus-stack/ @gehlotanish @Manjeet-Nethermind
-/charts/lodestar/ @aivarasko @matilote @refl3ction @stdevMac
+/charts/lodestar/ @aivarasko @matilote @0xDones @stdevMac
 /charts/loki/ @gehlotanish @Manjeet-Nethermind
 /charts/mev-boost/ @aivarasko @matilote
 /charts/mysql/ @gehlotanish @Manjeet-Nethermind
 /charts/nethgate/ @gehlotanish @Manjeet-Nethermind
 /charts/posmoni/ @aivarasko @matilote
 /charts/promtail/ @gehlotanish @Manjeet-Nethermind
 /charts/rpc-saas-secretStore/ @gehlotanish @Manjeet-Nethermind
+/charts/ssv-node/ @matilote @0xDones
 /charts/validator-ejector/ @aivarasko @matilote
 /charts/validator-kapi/ @aivarasko @matilote
 /charts/validators/ @aivarasko @matilote

charts/lodestar/Chart.yaml

@@ -15,10 +15,10 @@ type: application
 # This is the chart version. This version number should be incremented each time you make changes
 # to the chart and its templates, including the app version.
 # Versions are expected to follow Semantic Versioning (https://semver.org/)
-version: 0.1.1
+version: 0.1.2
 
 maintainers:
   - name: matilote
   - name: aivarasko
   - name: stdevMac
-  - name: refl3ction
+  - name: 0xDones

charts/lodestar/README.md

@@ -1,6 +1,6 @@
 # lodestar
 
-![Version: 0.1.1](https://img.shields.io/badge/Version-0.1.1-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square)
+![Version: 0.1.2](https://img.shields.io/badge/Version-0.1.2-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square)
 
 A Helm chart to deploy the Lodestar Consensus Client using Kubernetes
 
@@ -18,6 +18,8 @@ A Helm chart to deploy the Lodestar Consensus Client using Kubernetes
 | Key | Type | Default | Description |
 |-----|------|---------|-------------|
 | affinity | object | `{}` |  |
+| config.extraArgs | string | `""` |  |
+| config.metricsEnabled | bool | `true` |  |
 | env[0].name | string | `"BEACON_NODE_ADDRESS"` |  |
 | env[0].value | string | `""` |  |
 | env[1].name | string | `"NETWORK"` |  |
@@ -29,7 +31,7 @@ A Helm chart to deploy the Lodestar Consensus Client using Kubernetes
 | fullnameOverride | string | `""` |  |
 | image.pullPolicy | string | `"IfNotPresent"` |  |
 | image.repository | string | `"chainsafe/lodestar"` |  |
-| image.tag | string | `"v1.11.3"` |  |
+| image.tag | string | `"v1.19.0"` |  |
 | imagePullSecrets | list | `[]` |  |
 | ingress.annotations | object | `{}` |  |
 | ingress.className | string | `""` |  |
@@ -59,4 +61,4 @@ A Helm chart to deploy the Lodestar Consensus Client using Kubernetes
 | tolerations | list | `[]` |  |
 
 ----------------------------------------------
-Autogenerated from chart metadata using [helm-docs v1.12.0](https://github.com/norwoodj/helm-docs/releases/v1.12.0)
+Autogenerated from chart metadata using [helm-docs v1.14.2](https://github.com/norwoodj/helm-docs/releases/v1.14.2)

charts/lodestar/templates/configmap.yaml

@@ -9,7 +9,7 @@ data:
   run.sh: |
     #!/bin/sh
 
-    for f in /home/charon/validator_keys/keystore-*.json; do
+    for f in /home/lodestar/validator_keys/keystore-*.json; do
       echo "Importing key ${f}"
 
       # Import keystore with password.
@@ -25,10 +25,10 @@ data:
     exec node /usr/app/packages/cli/bin/lodestar validator \
         --dataDir="/opt/data" \
         --network="$NETWORK" \
-        --metrics=true \
+        --metrics={{ .Values.config.metricsEnabled }} \
         --metrics.address="0.0.0.0" \
         --metrics.port={{ .Values.service.ports.metrics }} \
         --beaconNodes="$BEACON_NODE_ADDRESS" \
         --builder="$BUILDER_API_ENABLED" \
         --builder.selection="$BUILDER_SELECTION" \
-        --distributed
+        --distributed {{ .Values.config.extraArgs | default "" }}

charts/lodestar/templates/statefulset.yaml

@@ -10,6 +10,7 @@ spec:
   selector:
     matchLabels:
       {{- include "lodestar.selectorLabels" . | nindent 6 }}
+  serviceName: "{{ include "lodestar.fullname" . }}"
   template:
     metadata:
       {{- with .Values.podAnnotations }}
@@ -55,7 +56,7 @@ spec:
           volumeMounts:
             - mountPath: /opt/lodestar
               name: data
-            - mountPath: /home/charon/validator_keys
+            - mountPath: /home/lodestar/validator_keys
               name: validator-keys
           env:
             {{- toYaml .Values.env | nindent 12 }}

charts/lodestar/values.yaml

@@ -8,12 +8,16 @@ image:
   repository: chainsafe/lodestar
   pullPolicy: IfNotPresent
   # Overrides the image tag whose default is the chart appVersion.
-  tag: "v1.11.3"
+  tag: "v1.19.0"
 
 imagePullSecrets: []
 nameOverride: ""
 fullnameOverride: ""
 
+config:
+  metricsEnabled: true
+  extraArgs: ""
+
 env:
   - name: "BEACON_NODE_ADDRESS"
     value: ""