[ssv-node] add ssv-node chart #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matilote
approved these changes
Jun 20, 2024
AntiD2ta
reviewed
Jun 20, 2024
| apiVersion: v1 | ||
| kind: Service | ||
| metadata: | ||
| name: "{{ include "ssv-node.fullname" . }}" |
There was a problem hiding this comment.
Do you think this should have a suffix name as well?
There was a problem hiding this comment.
Or perhaps the p2p one should be the main and this a metrics one.
There was a problem hiding this comment.
That's a good question, sir. I believe the suffix is not needed for the generic service, I added it to the p2p one because I wanted to be specific about it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ssv-node