fix: Resolve null reference and constructor argument errors in AdminR…

…pcModule
NethermindEth · Feb 13, 2025 · 251c554 · 251c554
1 parent 92988d6
commit 251c554
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/src/Nethermind/Nethermind.Init/Steps/RegisterRpcModules.cs b/src/Nethermind/Nethermind.Init/Steps/RegisterRpcModules.cs
@@ -76,6 +76,7 @@ public virtual async Task Execute(CancellationToken cancellationToken)
         StepDependencyException.ThrowIfNull(_api.SyncServer);
         StepDependencyException.ThrowIfNull(_api.EngineSignerStore);
         StepDependencyException.ThrowIfNull(_api.EthereumEcdsa);
+        StepDependencyException.ThrowIfNull(_api.TrustedNodesManager);
 
         if (!_jsonRpcConfig.Enabled)
         {

diff --git a/src/Nethermind/Nethermind.JsonRpc.Test/Modules/AdminModuleTests.cs b/src/Nethermind/Nethermind.JsonRpc.Test/Modules/AdminModuleTests.cs
@@ -325,7 +325,8 @@ public async Task Test_admin_addTrustedPeer()
             _exampleDataDir,
             new ManualPruningTrigger(),
             chainSpec.Parameters,
-            trustedNodesManager);
+            trustedNodesManager,
+            _subscriptionManager);
 
         // Call admin_addTrustedPeer via the RPC test helper
         string serialized = await RpcTest.TestSerializedRequest(adminRpcModule, "admin_addTrustedPeer", _enodeString);

diff --git a/src/Nethermind/Nethermind.JsonRpc/Modules/Admin/AdminRpcModule.cs b/src/Nethermind/Nethermind.JsonRpc/Modules/Admin/AdminRpcModule.cs
@@ -51,7 +51,9 @@ public AdminRpcModule(
         IAdminEraService eraService,
         string dataDir,
         ManualPruningTrigger pruningTrigger,
-        ChainParameters parameters)
+        ChainParameters parameters,
+        ITrustedNodesManager trustedNodesManager,
+        ISubscriptionManager subscriptionManager)
     {
         _enode = enode ?? throw new ArgumentNullException(nameof(enode));
         _dataDir = dataDir ?? throw new ArgumentNullException(nameof(dataDir));