Always trace invalid block even if succeeds on trace #8131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukaszRozmej
approved these changes
Jan 30, 2025
Comment on lines
+55
to
+75
| string condition; | ||
| string blockHash; | ||
| if (blocksOrHash is Hash256 failedBlockHash) | ||
| { | ||
| condition = "invalid"; | ||
| blockHash = failedBlockHash.ToString(); | ||
| } | ||
| else | ||
| { | ||
| List<Block> blocks = blocksOrHash as List<Block>; | ||
| condition = "valid on rerun"; | ||
|
|
||
| if (blocks.Count == 1) | ||
| { | ||
| blockHash = blocks[0].Hash.ToString(); | ||
| } | ||
| else | ||
| { | ||
| blockHash = string.Join("|", blocks.Select(b => b.Hash.ToString())); | ||
| } | ||
| } |
There was a problem hiding this comment.
Maybe put that in separate method
|
After more thought, I am not sure if this is useful? |
It does specify if valid or invalid logs; and some logs is better than none (so at least can see what type of thing is in the block) |
|
should we add valid/invalid info to file name? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Types of changes
What types of changes does your code introduce?
Testing
Requires testing