Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(oas): support for vendor extensions for example values in swagger #225

Merged
merged 20 commits into from
Feb 27, 2024
Merged

feat(oas): support for vendor extensions for example values in swagger #225

merged 20 commits into from
Feb 27, 2024

Conversation

ostridm
Copy link
Contributor

@ostridm ostridm commented Feb 12, 2024

closes #224

@ostridm ostridm added the Type: enhancement New feature or request. label Feb 12, 2024
@ostridm ostridm self-assigned this Feb 12, 2024
@codeclimate CodeClimate
Copy link

codeclimate bot commented Feb 12, 2024 •
edited
Loading

Code Climate has analyzed commit 1192135 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 98.1% (50% is the threshold).

This pull request will bring the total coverage in the repository to 92.1% (0.2% change).

View more on Code Climate.

@ostridm ostridm marked this pull request as ready for review February 13, 2024 08:26
@ostridm ostridm enabled auto-merge (squash) February 13, 2024 08:26
@ostridm ostridm requested a review from pmstss February 13, 2024 09:01
pmstss
pmstss requested changes Feb 14, 2024
View reviewed changes
Copy link
Contributor

@pmstss pmstss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, thanks! 👍
I've left some comments for improvement, but overall the changes look promising

packages/oas/src/converter/VendorExtensions.ts Outdated Show resolved Hide resolved
packages/openapi-sampler/src/VendorExtensions.ts Outdated Show resolved Hide resolved
packages/oas/src/index.ts Outdated Show resolved Hide resolved
packages/oas/src/converter/Sampler.ts Show resolved Hide resolved
packages/oas/src/converter/Sampler.ts Outdated Show resolved Hide resolved
packages/openapi-sampler/tests/VendorExamples.spec.ts Outdated Show resolved Hide resolved
packages/openapi-sampler/tests/VendorExamples.spec.ts Outdated Show resolved Hide resolved
packages/openapi-sampler/tests/VendorExamples.spec.ts Outdated Show resolved Hide resolved
packages/openapi-sampler/tests/VendorExamples.spec.ts Outdated Show resolved Hide resolved
packages/openapi-sampler/tests/VendorExamples.spec.ts Outdated Show resolved Hide resolved
@pmstss pmstss changed the title feat(oas): introduce support for examples vendor extensions in Swagger converter feat(oas): support for vendor extensions for example values in swagger Feb 14, 2024
ostridm added 13 commits February 15, 2024 19:07
@ostridm
refactor(oas): adjust according to code review
255ec3d 
closes #224
@ostridm
refactor(oas): fix formatting
15183c3 
closes #224
@ostridm
refactor(oas): adjust according to code review
905258c 
closes #224
@ostridm
refactor(oas): address complexity issues
8a1b527 
closes #224
@ostridm
refactor(oas): address complexity issues
4fead7b 
closes #224
@ostridm
refactor(oas): address complexity issues
84344aa 
closes #224
@ostridm
refactor(oas): address complexity issues
928930e 
closes #224
@ostridm
refactor(oas): address complexity issues
f3a4527 
closes #224
@ostridm
refactor(oas): address duplication issues
d3029a7 
closes #224
@ostridm
refactor(oas): address duplication issues
1d5e320 
closes #224
@ostridm
refactor(oas): address duplication issues
8da9097 
closes #224
@ostridm
refactor(oas): address duplication issues
54ca343 
closes #224
@ostridm
refactor(oas): address duplication issues
b01a3c2 
closes #224
@ostridm ostridm requested review from pmstss and derevnjuk and removed request for pmstss February 16, 2024 12:18
@ostridm ostridm requested a review from pmstss February 26, 2024 12:45
@ostridm ostridm removed the request for review from derevnjuk February 26, 2024 12:58
pmstss
pmstss requested changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@pmstss pmstss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thank you! 👍
Just a few adjustments to consider - please review the comments.

packages/oas/tests/fixtures/x-example.body.disabled.smatrbear.swagger.result.json Outdated Show resolved Hide resolved
packages/openapi-sampler/src/traverse/VendorExampleExtractor.ts Outdated Show resolved Hide resolved
packages/oas/tests/DefaultConverter.spec.ts Outdated Show resolved Hide resolved
packages/oas/tests/DefaultConverter.spec.ts Outdated Show resolved Hide resolved
@ostridm ostridm requested a review from pmstss February 27, 2024 06:24
pmstss
pmstss approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@pmstss pmstss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@ostridm ostridm merged commit a47621a into master Feb 27, 2024
6 checks passed
@ostridm ostridm deleted the feat_#224/introduce-support-of-x-example-extension-in-swagger branch February 27, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmstss pmstss pmstss approved these changes

Assignees

@ostridm ostridm

Labels
Type: enhancement New feature or request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add vendor examples extension support to Swagger converter
2 participants
@ostridm @pmstss