-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Thielen2015 c-VEP dataset #557
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thijor Thielen2015
and Thielen2021
share multiple methods copy/pasted methods. I think it would make sense to define them both in the same thielen.py
file with a common parent class to facilitate maintenance in the future. Lee2019
for example does this
You are right, Pierre. However, also the castillos2023 dataset uses these functions, as these are the ones that embed epoch and trial information in the datasets as separate stim channels. So a general thielen.py is not handy. Would be more like utils. Where would you want to put it then? |
Then I think these functions would fit in |
This pull request adds the Thielen et al. 2015 c-VEP dataset. Additionally, it fixes issue #555 regarding the Thielen et al. 2021 dataset, and issue #554 that fixes a bug and makes datasets in the c-VEP paradigm searchable.