Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Within Session splitter #664

Open
wants to merge 82 commits into
base: develop
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
82 commits
Select commit Hold shift + click to select a range
bacedc5
Creating new splitters and base evaluation
brunaafl Jun 6, 2024
419b2ca
Adding metasplitters
brunaafl Jun 7, 2024
d6e795d
Fixing LazyEvaluation
brunaafl Jun 10, 2024
140670c
Merge branch 'NeuroTechX:develop' into eval_splitters
brunaafl Jun 10, 2024
d724674
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jun 10, 2024
a278026
More optimized version of TimeSeriesSplit
brunaafl Jun 10, 2024
300a6b9
More optimized version of TimeSeriesSplit
brunaafl Jun 10, 2024
7cb79f6
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jun 10, 2024
55db70f
Addressing some comments: documentation, types, inconsistencies
brunaafl Jun 10, 2024
2851a15
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jun 10, 2024
c73dd1a
Addressing some comments: optimizing code, adjusts
brunaafl Jun 12, 2024
2b0e735
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jun 12, 2024
cf4b709
Adding examples
brunaafl Jun 26, 2024
177bf65
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jun 26, 2024
a6b5772
Adding: Pytests for evaluation splitters, and examples for meta split…
brunaafl Aug 15, 2024
26b13d5
Changing: name of TimeSeriesSplit to PseudoOnlineSplit
brunaafl Sep 30, 2024
e6661c4
Merge branch 'develop' into eval_splitters
brunaafl Sep 30, 2024
430e3a8
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Sep 30, 2024
698e539
Fixing pre-commit
brunaafl Sep 30, 2024
0fff053
Merge remote-tracking branch 'origin/eval_splitters' into eval_splitters
brunaafl Sep 30, 2024
98d12ac
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Sep 30, 2024
558d27b
Adding some tests for metasplitters
brunaafl Oct 1, 2024
34ea645
Merge remote-tracking branch 'origin/eval_splitters' into eval_splitters
brunaafl Oct 1, 2024
b435bf8
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 1, 2024
d8f26a3
Fixing pre-commit
brunaafl Oct 1, 2024
eaf0fb9
Merge remote-tracking branch 'origin/eval_splitters' into eval_splitters
brunaafl Oct 1, 2024
e5159f2
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 1, 2024
516a5e8
Fixing pre-commit
brunaafl Oct 1, 2024
b29ecd2
Merge remote-tracking branch 'origin/eval_splitters' into eval_splitters
brunaafl Oct 1, 2024
37cff03
Fix example SamplerSplit
brunaafl Oct 17, 2024
88ee910
Add shuffle and random_state parameters to WithinSession
brunaafl Oct 18, 2024
ea9cc59
Change nomenclature of variables
brunaafl Oct 18, 2024
819c4ff
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 18, 2024
65c305e
Merge branch 'develop' into within_session
bruAristimunha Oct 18, 2024
f1ad587
FIX: fixing the whats_new.rst file
bruAristimunha Oct 18, 2024
485e7a5
EHN: playing a little
bruAristimunha Oct 18, 2024
3f3742f
FIX: fixing the import and docs/docstring
bruAristimunha Oct 18, 2024
c181c59
FIX: fixing the import and docs/docstring
bruAristimunha Oct 18, 2024
8f034c8
FIX: fixing the import and docs/docstring
bruAristimunha Oct 18, 2024
fbef726
FIX: removing cross-session and cross-subject
bruAristimunha Oct 18, 2024
837c061
FIX: focus only in the within-session
bruAristimunha Oct 18, 2024
34822e9
Merge branch 'develop' into within_session
bruAristimunha Oct 19, 2024
39e92e5
Fix test
brunaafl Oct 19, 2024
612c6a6
Merge remote-tracking branch 'origin/within_session' into within_session
brunaafl Oct 19, 2024
590edb1
[FIX] I think it is fixed.
bruAristimunha Oct 23, 2024
b151d61
[FIX] shuffle everything
bruAristimunha Oct 23, 2024
602ccd5
Merge remote-tracking branch 'origin/within_session' into within_session
brunaafl Oct 25, 2024
74cf246
Changing WithinSession image
brunaafl Oct 25, 2024
c85928d
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 25, 2024
f3020ee
Update moabb/evaluations/splitters.py
brunaafl Nov 25, 2024
c628fd7
Update moabb/evaluations/splitters.py
brunaafl Nov 25, 2024
83e425f
Update moabb/evaluations/splitters.py
brunaafl Nov 25, 2024
a785ef7
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 25, 2024
686572e
Merge branch 'develop' into within_session
bruAristimunha Nov 26, 2024
8f8ada9
Adding possibility of passing a specific cv to do inner cv
brunaafl Nov 29, 2024
b87cf25
Merge remote-tracking branch 'origin/within_session' into within_session
brunaafl Nov 29, 2024
42e6b7b
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 29, 2024
f66878a
Changing metasplitter behaviour to have the same behavior as other cr…
brunaafl Dec 8, 2024
71cebb1
Merge remote-tracking branch 'origin/within_session' into within_session
brunaafl Dec 8, 2024
a948175
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Dec 8, 2024
e276a32
Wrapper of KFold to instantiate a different cv for each group (subjec…
brunaafl Dec 17, 2024
feebe7d
Merge remote-tracking branch 'origin/within_session' into within_session
brunaafl Dec 17, 2024
ee584ef
Merge branch 'develop' into within_session
bruAristimunha Feb 7, 2025
65bcf38
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Feb 7, 2025
5a77a39
[FIX] pre-commit
bruAristimunha Feb 7, 2025
ef833f3
rename to rng
bruAristimunha Feb 7, 2025
5f7511f
Delete misplaced image
brunaafl Feb 7, 2025
634a4ee
Merge remote-tracking branch 'origin/within_session' into within_session
brunaafl Feb 7, 2025
bc65d20
remove repet img
bruAristimunha Feb 7, 2025
a1ca06f
Merge remote-tracking branch 'origin/within_session' into within_session
brunaafl Feb 7, 2025
410b462
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Feb 7, 2025
00f5ee8
[FIX] fix the splitter
bruAristimunha Feb 7, 2025
cfbbb52
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Feb 7, 2025
26d7378
[EHN] debuging a little
bruAristimunha Feb 7, 2025
f73fd5d
[EHN] fixing the test with Bruna
bruAristimunha Feb 7, 2025
09f3e3f
[EHN] removing pseudo-online as requested
bruAristimunha Feb 7, 2025
9352a6e
[EHN] removing pseudo-online as requested
bruAristimunha Feb 7, 2025
238f90a
[EHN] removing pseudo-online as requested
bruAristimunha Feb 7, 2025
9fcd1f5
Update moabb/evaluations/splitters.py
PierreGtch Feb 8, 2025
fc408e5
Update moabb/evaluations/splitters.py
bruAristimunha Feb 8, 2025
2663b16
Merge branch 'develop' into within_session
bruAristimunha Feb 9, 2025
6f5504f
Merge branch 'develop' into within_session
bruAristimunha Feb 13, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update moabb/evaluations/splitters.py
Co-authored-by: Thomas Moreau <[email protected]>
Signed-off-by: Bruna Junqueira Lopes <[email protected]>
brunaafl and tomMoral authored Nov 25, 2024

Verified

This commit was signed with the committer’s verified signature.
Ant0wan Antoine Barthelemy
commit c628fd7ce92c9449a9e3bb111f5c4453326ceee1
2 changes: 1 addition & 1 deletion moabb/evaluations/splitters.py
tomMoral marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
@@ -78,7 +78,7 @@ def get_n_splits(self, metadata):

def split(self, y, metadata, **kwargs):
all_index = metadata.index.values
subjects = metadata.subject.unique()
subjects = metadata['subject'].unique()

# Shuffle subjects if required
if self.shuffle_subjects: