-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow using empty array when indexing on DataStub object #605
Conversation
@lawrence-mbf I would value your input here. The proposed fix works in the specific situation, but if you have ideas on how to improve this, or if there are things I have overlooked please let me know. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #605 +/- ##
==========================================
- Coverage 95.44% 95.39% -0.05%
==========================================
Files 137 137
Lines 5265 5277 +12
==========================================
+ Hits 5025 5034 +9
- Misses 240 243 +3 ☔ View full report in Codecov by Sentry. |
Fix #595
Motivation
Fix issue.
How to test the behavior?
See issue #595
Example that works after the fix, but not before:
Checklist
fix #XX
whereXX
is the issue number?