Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Uncovered Types to Ecephys Tutorial #631

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Add Uncovered Types to Ecephys Tutorial #631

merged 1 commit into from
Nov 21, 2024

Conversation

ehennestad
Copy link
Collaborator

@ehennestad ehennestad commented Nov 21, 2024 •
edited
Loading

Motivation

Reach 100% type coverage in tutorials

How to test the behavior?

Run ecephys tutorial

Checklist

  • Have you ensured the PR description clearly describes the problem and solutions?
  • Have you checked to ensure that there aren't other open or previously closed Pull Requests for the same change?
  • If this PR fixes an issue, is the first line of the PR description fix #XX where XX is the issue number?

@ehennestad
Copy link
Collaborator Author

The failing test is related to this issue:
NeurodataWithoutBorders/nwbinspector#534

@bendichter bendichter merged commit cfb374c into master Nov 21, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bendichter bendichter bendichter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ehennestad @bendichter