Skip to content

Commit

Permalink
Make parameter types private
Browse files Browse the repository at this point in the history
  • Loading branch information
wallymathieu committed Feb 18, 2024
1 parent 0facd40 commit daef797
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
6 changes: 3 additions & 3 deletions MvcApp/Models.fs
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ type CustomerId =
with _ ->
result <- Unchecked.defaultof<_>
false
and internal CustomerId_T1 = ParseTypeConverter<CustomerId>
and private CustomerId_T1 = ParseTypeConverter<CustomerId>

[<Struct>]
[<TypeConverter(typeof<ProductId_T1>)>]
Expand All @@ -60,7 +60,7 @@ type ProductId =
with _ ->
result <- Unchecked.defaultof<_>
false
and internal ProductId_T1 = ParseTypeConverter<ProductId>
and private ProductId_T1 = ParseTypeConverter<ProductId>

[<Struct>]
[<TypeConverter(typeof<OrderId_T1>)>]
Expand All @@ -78,7 +78,7 @@ type OrderId =
with _ ->
result <- Unchecked.defaultof<_>
false
and internal OrderId_T1 = ParseTypeConverter<OrderId>
and private OrderId_T1 = ParseTypeConverter<OrderId>

type Customer = {Id:CustomerId; FirstName:string ; LastName:string; Version:int}

Expand Down
4 changes: 2 additions & 2 deletions Tests/Handle_discriminated_union.fs
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ type ParseValueType =
with _ ->
result <- Unchecked.defaultof<_>
false
and internal ParseValueType_T1 = ParseTypeConverter<ParseValueType>
and internal ParseValueType_T2 = ParseTypeJsonConverter<ParseValueType>
and private ParseValueType_T1 = ParseTypeConverter<ParseValueType>
and private ParseValueType_T2 = ParseTypeJsonConverter<ParseValueType>


[<Serializable>]
Expand Down
2 changes: 1 addition & 1 deletion Tests/Parse_fs_type.fs
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ with
with _ ->
result <- Unchecked.defaultof<_>
false
and internal ParseValueType_T1 = ParseTypeConverter<ParseValueType>
and private ParseValueType_T1 = ParseTypeConverter<ParseValueType>

[<Serializable>]
[<CLIMutable>]
Expand Down

0 comments on commit daef797

Please sign in to comment.