refac: 공연 상세는 레이지 로딩 하지 않으며 레이웃은 라우터에서 주입 #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alstn2468
commented
Oct 11, 2024
Comment on lines
+80
to
+85
| onMouseDown={() => { | ||
| queryClient.prefetchQuery(queryKeys.show.detail(id)); | ||
| queryClient.prefetchQuery(queryKeys.host.me(id)); | ||
| queryClient.prefetchQuery(queryKeys.show.lastSettlementEvent(id)); | ||
| queryClient.prefetchQuery(queryKeys.show.settlementInfo(id)); | ||
| }} |
There was a problem hiding this comment.
레이아웃에서 데이터 없으면 문제가 생기므로 클릭시 미리 데이터 패칭
| @@ -99,7 +99,6 @@ const ShowCastInfoFormDialogContent = ({ onDelete, prevShowCastInfo, onSave }: P | |||
| <Styled.Row key={field._id}> | |||
| <Controller | |||
| control={control} | |||
| defaultValue={field.userCode} | |||
There was a problem hiding this comment.
요 수정 사항은 콘솔에서 에러 발생해서 controlled input에서 defalutValue를 주입하는 곳은 제거
Comment on lines
+133
to
+147
| { | ||
| path: '/', | ||
| element: ( | ||
| <ShowDetailLayout> | ||
| <Outlet /> | ||
| </ShowDetailLayout> | ||
| ), | ||
| children: [ | ||
| { path: PATH.SHOW_INFO, element: <ShowInfoPage /> }, | ||
| { path: PATH.SHOW_TICKET, element: <ShowTicketPage /> }, | ||
| { path: PATH.SHOW_RESERVATION, element: <ShowReservationPage /> }, | ||
| { path: PATH.SHOW_ENTRANCE, element: <ShowEnterancePage /> }, | ||
| { path: PATH.SHOW_SETTLEMENT, element: <ShowSettlementPage /> }, | ||
| ], | ||
| }, |
There was a problem hiding this comment.
레이아웃 사용하는 부분만 서브 라우터 분리
| fontSize: '12px', | ||
| }; | ||
|
|
||
| const TabItem = ({ type }: TabItemProps) => { |
There was a problem hiding this comment.
파일을 따로 빼기는 애매해서 한 파일안에 넣어둠
| @@ -1,19 +1,23 @@ | |||
| export const PATH = { | |||
There was a problem hiding this comment.
수정사항은 없고 연관이 있는 것 끼리 또는 헷갈리지 않도록 개행 추가함
|
사용성에 이슈가 있는 작업이라 먼저 머지합니다~ 후리뷰 부탁쓰 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
해당 작업 이유
기존 구조에서 레이아웃 분리해 둔 것은 그냥 유지하는 방향으로 PR을 올립니다.
커밋을 나눠야하나.. 와다다 개발해버린 관계로 쪼갤 수 없게된 점.. 양해 부탁드립니다