feat: 내기록 탭 > 미션별 내 상세 기록 조회 API #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
songyi00
force-pushed
the
feat/#117-my-record-detail
branch
from
1a45a34 to
dd1b1d6
Compare
kimyu0218
approved these changes
Jan 29, 2025
| it.getImageUrl(), | ||
| it.getCreatedAt())) | ||
| .toList(); | ||
| Long totalCount = missionVerificationRepository.countByMemberIdAndMissionId(memberId, missionId); |
There was a problem hiding this comment.
사소하지만 반환형이 long이어도 될 것 같아요!
|
|
||
| @Builder | ||
| public record VerificationWrapper( | ||
| @Schema(description = "총 개수", requiredMode = Schema.RequiredMode.REQUIRED) |
There was a problem hiding this comment.
- 미션 인증 내역의 개수인가요??! (= 내 인증 횟수)
- 피그마 내 기록에
8/10칸이라고 되어있는데 총 칸 횟수는 클라이언트에서 미션 id를 통해 넣어주는 건가요? 그렇다면 미션 이름도 미션 id로 조회해서 넣어줘도 될 것 같습니다!- (제가 본 화면이
내 기록(ios) | 내기록 - 완료미션 존재인데 제가 이상한 화면을 보고 있었다면 말씀해주세요 🥺)
- (제가 본 화면이
There was a problem hiding this comment.
아 이거 사진 클릭했을 때 보이는 인증 기록 목록 조회하는 API라 칸 횟수는 필요 없엉 저 totalCount는 페이징 할 때 필요한 총 개수야!
유정이가 말한 화면은 저번 PR API였당 ㅎㅎ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
close: #117
작업 개요
작업 사항
고민한 점들(필수 X)
여기에 작성하세요
스크린샷(필수 X)
여기에 작성하세요