Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] 웹뷰 브릿지 기초 구현 #11

Merged
merged 6 commits into from
Feb 3, 2025
Merged

[feat] 웹뷰 브릿지 기초 구현 #11

merged 6 commits into from
Feb 3, 2025

Conversation

sxunea
Copy link
Collaborator

@sxunea sxunea commented Feb 1, 2025 •
edited
Loading

Description

  • 웹뷰와의 소통을 위한 WebInterface (WebBridge) 구현
  • 웹뷰 내의 JavaScript에서 Android 메서드를 호출할 수 있도록 @JavascriptInterface 애노테이션을 사용한 브릿지 구현
  • WebViewState, WebViewEvent 구현하여 MVI 패턴으로 웹뷰 로드 및 js 이벤트 구독, ui 업데이트할 수 있도록 구현

To Reviewer

  • 아직 실 로직은 구현안하고 틀만 구현해두었어요 ~ !

@sxunea sxunea requested a review from freeskyES February 1, 2025 08:14
@sxunea sxunea self-assigned this Feb 1, 2025
freeskyES
freeskyES reviewed Feb 1, 2025
View reviewed changes
Copy link
Member

@freeskyES freeskyES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

전체적으로 깔끔하게 잘 구현했다 🙌
여기서 WebView 응답도 MVI 패턴으로 구조화해보면 좋을 것 같아요.

@sxunea sxunea merged commit d4d93f2 into develop Feb 3, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freeskyES freeskyES freeskyES left review comments

Assignees

@sxunea sxunea

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sxunea @freeskyES