feat: 선택 가능한 어조를 조회한다 #14
Merged
+45
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devxb
reviewed
Jan 29, 2025
src/main/kotlin/me/misik/api/api/response/ReviewStyleResponse.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/me/misik/api/api/response/ReviewStyleResponse.kt
Outdated
Show resolved
Hide resolved
devxb
approved these changes
Jan 30, 2025
inpink
added a commit
that referenced
this pull request
Jan 30, 2025
* feat: 선택 가능한 어조를 조회한다 * refactor: Enum 요소를 가져오는 방법을 수정한다
inpink
added a commit
that referenced
this pull request
Feb 4, 2025
* feat: 선택 가능한 어조를 조회한다 * refactor: Enum 요소를 가져오는 방법을 수정한다
inpink
added a commit
that referenced
this pull request
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요약
선택 가능한 어조와 해당되는 그래픽 이미지를 조회합니다
어떻게 구현했는지
그래픽 이미지는 클라이언트쪽에서 렌더링하기에 NCP Object Storage에 공개로 등록된 이미지의 링크를 반환
현재는 ReviewStyle이 하드코딩 되어있지만, 추후에 DB에서 관리할 가능성이 있어 ReviewStyleService 레이어 추가
이슈번호
close #10