[Feat/#24] Tag 컴포넌트 제작 #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
1 task
|
🧷 Storybook: https://6798a432c75b75bf6b81bc26-abgkqxrnab.chromatic.com/ ⏰ Update: 2025년 02월 01일 16시 20분 |
lgrin-byte
approved these changes
Feb 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 변경사항 & 이슈
Tag 컴포넌트 제작
✍️ 관련 설명
현재 디자인 상에서는 해시태그 선택 페이지에서만 해당되는 컴포넌트이지만 이후 더 추가될 수 있을 거 같고 아니더라도 Button 컴포넌트와는 차별점을 두기 위해서 Tag 컴포넌트를 만들어 봤어
일반적인 태그 primary variant랑, 아이콘 버튼 태그인 add variant로 나눠서 제작했고 선택 태그의 경우 isSelect props로 구분을 줬으니 확인해보면 될 거 같아
동일하게 스토리북도!
⭐️ Review point
📷 Demo