Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat/#38] 리뷰생성완료 화면 UI 제작 #43

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

lgrin-byte
Copy link
Member

💡 변경사항 & 이슈


리뷰 생성 완료 화면 구현

✍️ 관련 설명


페이지 url은 /receipt-result confetti를 추가하긴 했는데 임시로 넣은거라 컨펌필요할 것 같으! 나머지는 ui만 한거라 특이사항없을 것 같애

⭐️ Review point

confetti 더 괜찮은 라이브러리나 개선점
이외 코드 개선점


📷 Demo

2025-02-02.10.12.03.mov

@lgrin-byte lgrin-byte requested a review from sikkzz as a code owner February 2, 2025 13:19
@lgrin-byte lgrin-byte self-assigned this Feb 2, 2025
Copy link

github-actions bot commented Feb 2, 2025

🧷 Storybook: https://6798a432c75b75bf6b81bc26-kfbrunejvq.chromatic.com/

⏰ Update: 2025년 02월 02일 23시 20분

Copy link
Collaborator

@sikkzz sikkzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿굿 크리티컬한 이슈는 없어 보입니당!

confetti는 나도 써본게 없어서 그냥 잘 돌아가는 이거 우선 써도 괜찮을 거 같아~~

package.json Outdated Show resolved Hide resolved
src/components/ReceiptResult/Confetti.tsx Outdated Show resolved Hide resolved
src/components/ReceiptResult/ReceiptResult.module.scss Outdated Show resolved Hide resolved
src/components/ReceiptResult/ReceiptResult.tsx Outdated Show resolved Hide resolved
src/types/canvas-confetti.d.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants