-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat/#38] 리뷰생성완료 화면 UI 제작 #43
Open
lgrin-byte
wants to merge
9
commits into
develop
Choose a base branch
from
feat/#38
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🧷 Storybook: https://6798a432c75b75bf6b81bc26-kfbrunejvq.chromatic.com/ ⏰ Update: 2025년 02월 02일 23시 20분 |
sikkzz
requested changes
Feb 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
굿굿 크리티컬한 이슈는 없어 보입니당!
confetti는 나도 써본게 없어서 그냥 잘 돌아가는 이거 우선 써도 괜찮을 거 같아~~
sikkzz
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 변경사항 & 이슈
리뷰 생성 완료 화면 구현
✍️ 관련 설명
페이지 url은 /receipt-result confetti를 추가하긴 했는데 임시로 넣은거라 컨펌필요할 것 같으! 나머지는 ui만 한거라 특이사항없을 것 같애
⭐️ Review point
confetti 더 괜찮은 라이브러리나 개선점
이외 코드 개선점
📷 Demo
2025-02-02.10.12.03.mov