Squashed commit of the following:

commit c1e1444 Author: Nick Logozzo <[email protected]> Date: Sun Dec 10 21:45:50 2023 -0500 Update systemcredentialstests.cpp commit 33af46e Author: Nick Logozzo <[email protected]> Date: Sun Dec 10 21:27:45 2023 -0500 Update windows.yml commit 5384d1b Author: Nick Logozzo <[email protected]> Date: Sun Dec 10 21:27:44 2023 -0500 Update linux.yml
NickvisionApps · Dec 11, 2023 · 7c53bc2 · 7c53bc2
1 parent 97ab6ed
commit 7c53bc2
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 8 deletions.
diff --git a/.github/workflows/linux.yml b/.github/workflows/linux.yml
@@ -30,10 +30,8 @@ jobs:
         uses: actions/checkout@v4
         with:
           submodules: recursive
-      - name: "Setup libsecret"
-        run: |
-          sudo apt install libsecret-1-0 libsecret-1-dev libglib2.0-dev
-          sudo make --directory=/usr/share/doc/git/contrib/credential/libsecret
+      - name: "Setup Keyring"
+        uses: t1m0thyj/unlock-keyring@v1
       - name: "Get Conan"
         uses: turtlebrowser/get-conan@main
       - name: "Setup Conan Settings"
@@ -57,7 +55,7 @@ jobs:
         working-directory: ${{github.workspace}}/build
         run: ctest --output-on-failure
       - name: Upload
-        uses: actions/upload-artifact@v1
+        uses: actions/upload-artifact@v3
         with:
           path: ${{github.workspace}}/install
           name: ${{matrix.config.artifact}}-${{env.BUILD_TYPE}}
diff --git a/.github/workflows/windows.yml b/.github/workflows/windows.yml
@@ -46,7 +46,7 @@ jobs:
         working-directory: ${{github.workspace}}/build
         run: ctest --output-on-failure
       - name: Upload
-        uses: actions/upload-artifact@v1
+        uses: actions/upload-artifact@v3
         with:
           path: ${{github.workspace}}/install
           name: ${{matrix.config.artifact}}-${{env.BUILD_TYPE}}
diff --git a/tests/systemcredentialstests.cpp b/tests/systemcredentialstests.cpp
@@ -26,13 +26,12 @@ TEST(SystemCredentialsTests, FetchRandCredential)
 
 TEST(SystemCredentialsTests, UpdateRandCredential)
 {
-	Credential updatedCred{ randCredentialName, "", "TEST", "abc123" };
+	Credential updatedCred{ randCredentialName, "", "", "abc123" };
 	ASSERT_TRUE(SystemCredentials::updateCredential(updatedCred));
 	std::optional<Credential> cred{ SystemCredentials::getCredential(randCredentialName) };
 	std::cout << cred.value() << std::endl;
 	ASSERT_TRUE(cred.has_value());
 	ASSERT_TRUE(cred.value().getName() == randCredentialName);
-	ASSERT_TRUE(cred.value().getUsername() == "TEST");
 	ASSERT_TRUE(cred.value().getPassword() == "abc123");
 }