Linux/macOS - Fix Build

NickvisionApps · Aug 14, 2024 · bcc7038 · bcc7038
1 parent 5fbf9c9
commit bcc7038
Show file tree

Hide file tree

Showing 6 changed files with 17 additions and 5 deletions.
diff --git a/.github/workflows/linux.yml b/.github/workflows/linux.yml
@@ -40,7 +40,7 @@ jobs:
         with:
           pkgs: curl gettext-libintl glib gtest jsoncpp libsecret maddy openssl
           triplet: x64-linux
-          revision: fe1cde61e971d53c9687cf9a46308f8f55da19fa
+          revision: a4cfba036f013aea0347c3efc335186754b696b3
           token: ${{ secrets.GITHUB_TOKEN }}
           github-binarycache: true
       - name: "Build"

diff --git a/.github/workflows/macos.yml b/.github/workflows/macos.yml
@@ -31,7 +31,7 @@ jobs:
         with:
           pkgs: curl gettext-libintl glib gtest jsoncpp maddy openssl
           triplet: arm64-osx
-          revision: fe1cde61e971d53c9687cf9a46308f8f55da19fa
+          revision: a4cfba036f013aea0347c3efc335186754b696b3
           token: ${{ secrets.GITHUB_TOKEN }}
           github-binarycache: true
       - name: "Build"

diff --git a/.github/workflows/windows.yml b/.github/workflows/windows.yml
@@ -29,7 +29,7 @@ jobs:
         with:
           pkgs: curl gettext-libintl gtest jsoncpp maddy sqlcipher
           triplet: x64-windows
-          revision: fe1cde61e971d53c9687cf9a46308f8f55da19fa
+          revision: a4cfba036f013aea0347c3efc335186754b696b3
           token: ${{ secrets.GITHUB_TOKEN }}
           github-binarycache: true
       - name: "Build"

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,14 @@
 # Changelog
 
+## 2024.8.2 (next)
+### Breaking Changes
+None
+### New APIs
+None
+### Fixes
+#### System
+- Fixed reading console output from `Nickvision::System::Process` on linux
+
 ## 2024.8.1
 ### Breaking Changes
 None

diff --git a/manual/README.md b/manual/README.md
@@ -6,14 +6,14 @@
 
 libnick provides Nickvision apps with a common set of cross-platform APIs for managing system and desktop app functionality such as network management, taskbar icons, translations, app updates, and more.
 
-## 2024.8.1
+## 2024.8.2 (next)
 ### Breaking Changes
 None
 ### New APIs
 None
 ### Fixes
 #### System
-- Improved `Nickvision::System::Process`'s handling of arguments
+- Fixed reading console output from `Nickvision::System::Process` on linux
 
 ## Dependencies
 The following are a list of dependencies used by libnick. 

diff --git a/src/system/process.cpp b/src/system/process.cpp
@@ -241,6 +241,9 @@ namespace Nickvision::System
 
     void Process::watch()
     {
+#ifdef __linux__
+        int status{ 0 };
+#endif
         bool ended{ false };
         while(!ended)
         {