-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to .NET 6 #29
Update to .NET 6 #29
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good!
I would be willing to pull this into the dev branch as soon as you mark it completed. The only thing I would want to test and verify is the Updater (from framework to core) as well as (core to core)
I believe the updater works from Core to Core, but I have seen a potential issue (clowd/Clowd.Squirrel#9) with Framework to Core. I'll hopefully finish it by the end of the week andmark the PR as completed.
|
Just a note about You can publish your app as self-contained if that's suitable (thus bundling all your required dependencies) or alternatively, take care to install .net 6 yourself (using the new Squirrel runtime API's) before updating to a version that requires it. If you choose to do the latter, you should ship a release on Framework using |
Regarding the missing shortcuts, at the top of Program.cs, you need to add Another note about Program.cs:StartNewVersion() is that you can use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments.
@wiggleforlife I have taken a stab at making some improvements in my branch here https://github.com/caesay/FE-BUDDY/commits/dotnet6 - there is only two things todo yet, which is to write a build script that trims the publish assemblies (eg. WPF) so that FE-BUDDY releases can be smaller, and get delta updates working. I'll have a look at this soon. |
@caesay Thanks for all of this, you're being an absolutely massive help. I was going to look into replacing this with Squirrel's GitHub update system as well in the future, but since you're already doing it this makes everything a lot easier. Thanks again! |
Merge caesay/dotnet6 into nikolai558/dotnet6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are amazing changes, thank you both for your help with this. I have created pull requests to move it into the dotnet6 branch on my repo. I will probably merge that branch into dev then release a new version here soon.
See Nikolai558/NASR2SCT#127
Pretty much the same as my previous PR, except:
Microsoft aims for a .NET MAUI RC in Q1 and a final release in Q2.
Changes