18 update changes from crypto3 zk #19

vo-nil · 2023-10-26T19:30:16Z

This PR contains synchronization of current work at crypto3-zk with actor-zk
Additions include algorithmic performance improvements as well as addition of new mask parameter.

Adding some missing typedefs, they are used in marshalling.

* Updated the performance test. * Adding data for perf tests, updating the performance test * Changing the cpp and input files for merkle tree poseidon examples.

* Add lookup table definition type#190 * Update some types for blueprint compatibility#190 * Lookup table definition changed not to generate lookup table if it's not necessary#190 * Do lookup_table_definition_class abstract to generate tables only if we need them #190 * Add get_rows_number and get_columns_number to lookup table definition * Some changes after review #190

…1 by 1, it's faster that way. (#200)

* Add gate argument multiplication on mask #207 * Padding rows >= usable_rows with random numbers #211 * Derandomize placeholder_placeholder_test #211 * ACTOR_ZK_systems_plonk_plonk_constraint_test updated #211 * Add some includes #211 * Fixed polys values in _etha points is memorized in preprocessor #206 * Move commitment_scheme preprocessed data outside of commitment scheme object #206 * Minor changes in LPC#206

Zerg1996

I have minor code style notes.

Zerg1996 · 2023-10-27T08:50:45Z

include/nil/actor/zk/commitments/polynomial/kzg.hpp

@@ -600,7 +600,7 @@ namespace nil {

                    auto right = commit_g2<KZG>(params, create_polynom_by_zeros<KZG>(public_key.T));
                    auto right_side_pairing = crypto3::algebra::pair_reduced<typename KZG::curve_type>(proof, right);
-                    
+
                    return left_side_pairing == right_side_pairing;
                    // return true;


Let's remove commended lines?

removed in 62ff812

include/nil/actor/zk/commitments/polynomial/kzg.hpp

Zerg1996 · 2023-10-27T08:54:08Z

include/nil/actor/zk/commitments/polynomial/lpc.hpp

@@ -63,35 +65,52 @@ namespace nil {
                    using poly_type = PolynomialType;
                    using lpc = LPCScheme;
                    using eval_storage_type = typename LPCScheme::eval_storage_type;
+                    using preprocessed_data_type = std::map<std::size_t, std::vector<typename field_type::value_type>>;


We already declare
using value_type = typename field_type::value_type; so we can set preprocessed_data_type as
using preprocessed_data_type = std::map<std::size_t, std::vector<value_type>;

updated in 78fb71c

include/nil/actor/zk/commitments/polynomial/lpc.hpp

Zerg1996 · 2023-10-27T08:56:41Z

include/nil/actor/zk/math/non_linear_combination.hpp

@@ -129,7 +136,10 @@ namespace nil {
                    }
                    this->terms.clear();
                    for (const auto& it: unique_terms) {
-                        this->terms.emplace_back(it.first.get_vars(), it.second);
+                        if (it.second != assignment_type::zero())
+                        {


Let's use one code style for if/else constructions.

updated in 2c7efa0

Zerg1996 · 2023-10-27T08:59:23Z

include/nil/actor/zk/snark/arithmetization/plonk/detail/lookup_table_definition.hpp

+                        for( const auto&[k, table]:lookup_tables ){
+                            // Place table into constant_columns.
+                            for( std::size_t i = 0; i < table->get_table().size(); i++ ){
+                                if(constant_columns[i].size() < start_row + table->get_table()[i].size()){


Maybe let's add new variable
auto end = start_row + table->get_table()[i].size()
Because we use it's expression 4 times

updated in ab70e48

Zerg1996 · 2023-10-27T09:01:21Z

test/systems/plonk/placeholder/placeholder.cpp

@@ -615,13 +622,17 @@ ACTOR_THREAD_TEST_CASE(permutation_argument_test) {
    for (int i = 0; i < argument_size; i++) {
        BOOST_CHECK(prover_res.F_dfs[i].evaluate(y) == verifier_res[i]);
        for (std::size_t j = 0; j < desc.rows_amount; j++) {
-            BOOST_CHECK(
-                prover_res.F_dfs[i].evaluate(preprocessed_public_data.common_data.basic_domain->get_domain_element(j)) == field_type::value_type::zero());
+            if(prover_res.F_dfs[i].evaluate(preprocessed_public_data.common_data.basic_domain->get_domain_element(j)) != 0){


It's something interesting.
We always check inside prover values with field_type::value_type::zero()
Such case means - our equation not always correct?

It seems that some debug checks creeped in.
fixed in c1c33e8

ETatuzova and others added 10 commits October 25, 2023 19:32

Merge pull request #189 from NilFoundation/188-add-missing-typedefs

a2fca84

Adding some missing typedefs, they are used in marshalling.

191 update placeholder performance test (#192)

16a1631

* Updated the performance test. * Adding data for perf tests, updating the performance test * Changing the cpp and input files for merkle tree poseidon examples.

Small cleanup. (#196)

7dc2e57

In LPC proof instead of dividing by V, divide by smaller polynomials …

770f1e3

…1 by 1, it's faster that way. (#200)

Added sort_terms_by_degree function #202 (#203)

2033b18

Remove zero terms from non linear combination.

a0c42fb

Add gate argument multiplication on mask #207 (#208)

78b6f75

Fix copy-paste errors #18

0315aad

vo-nil requested review from martun and Zerg1996 October 26, 2023 19:31

vo-nil marked this pull request as draft October 26, 2023 19:33

vo-nil marked this pull request as ready for review October 27, 2023 06:14

Zerg1996 reviewed Oct 27, 2023

View reviewed changes

vo-nil added 5 commits October 30, 2023 20:27

remove commented return #18

62ff812

shortened declaration #18

78fb71c

replace expression with new var #18

ab70e48

update if/else code style #18

2c7efa0

fixed debug typos #18

c1c33e8

Zerg1996 self-requested a review October 30, 2023 18:16

Zerg1996 approved these changes Oct 30, 2023

View reviewed changes

vo-nil merged commit 1c63cc8 into master Oct 31, 2023
1 of 2 checks passed

vo-nil deleted the 18-update-changes-from-crypto3-zk branch October 31, 2023 07:38

This was referenced Oct 31, 2023

Synchronize changes with actor-zk NilFoundation/crypto3-zk#216

Closed

Reflect changes from actor-zk project #216 NilFoundation/crypto3-zk#217

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

18 update changes from crypto3 zk #19

18 update changes from crypto3 zk #19

vo-nil commented Oct 26, 2023 •

edited

Loading

Zerg1996 left a comment

Zerg1996 Oct 27, 2023

vo-nil Oct 30, 2023

Zerg1996 Oct 27, 2023

vo-nil Oct 30, 2023

Zerg1996 Oct 27, 2023

vo-nil Oct 30, 2023

Zerg1996 Oct 27, 2023

vo-nil Oct 30, 2023

Zerg1996 Oct 27, 2023

vo-nil Oct 30, 2023

18 update changes from crypto3 zk #19

18 update changes from crypto3 zk #19

Conversation

vo-nil commented Oct 26, 2023 • edited Loading

Zerg1996 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vo-nil commented Oct 26, 2023 •

edited

Loading