Merge branch 'master' into 67-cyclotomic-modular-ops

NilFoundation · Apr 20, 2024 · a18399b · a18399b
2 parents 139d4b0 + 0db22ac
commit a18399b
Show file tree

Hide file tree

Showing 27 changed files with 726 additions and 617 deletions.
diff --git a/.github/workflows/publish-results.yml b/.github/workflows/publish-results.yml
@@ -0,0 +1,13 @@
+# Needed to publish test results in fork
+name: Testing Callback
+
+on:
+  workflow_run:
+    workflows: ["PR Testing"]
+    types:
+      - completed
+
+jobs:
+  call-reusable-workflow:
+    name: Call Reusable Testing Callback Workflow
+    uses: NilFoundation/ci-cd/.github/workflows/reusable-crypto3-publish-result.yml@v1
diff --git a/.github/workflows/pull-request.yml b/.github/workflows/pull-request.yml
@@ -0,0 +1,24 @@
+name: PR Testing
+
+on:
+  pull_request:
+    types:
+      - opened
+      - synchronize
+
+jobs:
+  handle-syncwith:
+    name: Call Reusable SyncWith Handler
+    uses: NilFoundation/ci-cd/.github/workflows/[email protected]
+    with:
+      ci-cd-ref: 'v1.1.2'
+    secrets: inherit
+
+  matrix-test:
+    name: Call Reusable Crypto3 Testing
+    needs:
+      - handle-syncwith
+    uses: NilFoundation/ci-cd/.github/workflows/[email protected]
+    with:
+      submodules-refs: ${{ needs.handle-syncwith.outputs.prs-refs }}
+    secrets: inherit
diff --git a/include/nil/crypto3/detail/inline_variable.hpp b/include/nil/crypto3/detail/inline_variable.hpp
diff --git a/include/nil/crypto3/detail/make_array.hpp b/include/nil/crypto3/detail/make_array.hpp
diff --git a/include/nil/crypto3/detail/make_uint_t.hpp b/include/nil/crypto3/detail/make_uint_t.hpp
diff --git a/include/nil/crypto3/detail/state_adder.hpp b/include/nil/crypto3/detail/state_adder.hpp
diff --git a/include/nil/crypto3/detail/unbounded_shift.hpp b/include/nil/crypto3/detail/unbounded_shift.hpp
diff --git a/include/nil/crypto3/math/algorithms/make_evaluation_domain.hpp b/include/nil/crypto3/math/algorithms/make_evaluation_domain.hpp
@@ -49,6 +49,7 @@ namespace nil {
             */
             template<typename FieldType, typename ValueType = typename FieldType::value_type>
             std::shared_ptr<evaluation_domain<FieldType, ValueType>> make_evaluation_domain(std::size_t m) {
+
                 typedef std::shared_ptr<evaluation_domain<FieldType, ValueType>> result_type;
 
                 const std::size_t big = 1ul << (std::size_t(std::ceil(std::log2(m))) - 1);

diff --git a/include/nil/crypto3/math/detail/field_utils.hpp b/include/nil/crypto3/math/detail/field_utils.hpp
@@ -40,7 +40,7 @@ namespace nil {
 
                 using namespace nil::crypto3::algebra;
 
-                std::size_t bitreverse(std::size_t n, const std::size_t l) {
+                inline std::size_t bitreverse(std::size_t n, const std::size_t l) {
                     std::size_t r = 0;
                     for (std::size_t k = 0; k < l; ++k) {
                         r = (r << 1) | (n & 1);