Merge pull request #215 from NilFoundation/194-lookup-table-packer

Horizontal lookup packing algorithm.
NilFoundation · Nov 10, 2023 · 942ecc8 · 942ecc8
2 parents 623ec86 + b17646a
commit 942ecc8
Show file tree

Hide file tree

Showing 4 changed files with 418 additions and 177 deletions.
diff --git a/.github/workflows/run_tests.yml b/.github/workflows/run_tests.yml
@@ -97,7 +97,7 @@ jobs:
             # crypto3_zk_systems_pcd_r1cs_pcd_r1cs_mp_ppzkpcd_r1cs_mp_ppzkpcd_test
             # crypto3_zk_systems_plonk_pickles_kimchi_test
             # crypto3_zk_systems_plonk_pickles_oracles_test
- 
+
           ]  # Tests to execute
     steps:
       - name: Cleanup # TODO - move to scripts on runner

diff --git a/include/nil/crypto3/zk/snark/arithmetization/plonk/assignment.hpp b/include/nil/crypto3/zk/snark/arithmetization/plonk/assignment.hpp
@@ -272,11 +272,11 @@ namespace nil {
                         return _public_table.selector(index);
                     }
 
-                    void fill_constant(std::uint32_t index, const ColumnType& column) {
+                    virtual void fill_constant(std::uint32_t index, const ColumnType& column) {
                         _public_table.fill_constant(index, column);
                     }
 
-                    void fill_selector(std::uint32_t index, const ColumnType& column) {
+                    virtual void fill_selector(std::uint32_t index, const ColumnType& column) {
                         _public_table.fill_selector(index, column);
                     }
 

diff --git a/include/nil/crypto3/zk/snark/arithmetization/plonk/detail/lookup_table_definition.hpp b/include/nil/crypto3/zk/snark/arithmetization/plonk/detail/lookup_table_definition.hpp