Move random_test_initializer to separate file [SyncWith: crypto3-zk#328] #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
x-mass
changed the title
|
PRs, synced with the current issue: Note: Please do not edit this comment; it's generated automatically. |
x-mass
force-pushed
the
move-test-initializer
branch
from
d469024 to
99382c7
Compare
|
Tests will be run in sync with other PRs containing |
x-mass
force-pushed
the
move-test-initializer
branch
from
99382c7 to
2c082fd
Compare
martun
reviewed
May 10, 2024
| @@ -178,7 +84,6 @@ target_link_libraries(${CMAKE_WORKSPACE_NAME}_${CURRENT_PROJECT_NAME} INTERFACE | |||
| ${CMAKE_WORKSPACE_NAME}::hash | |||
| ${CMAKE_WORKSPACE_NAME}::multiprecision | |||
| ${CMAKE_WORKSPACE_NAME}::containers) | |||
| # marshalling::crypto3_zk) | |||
There was a problem hiding this comment.
We probably have this dependency, but we choose not to list it here, that's why we had this comment. But it's ok to delete it.
martun
approved these changes
May 10, 2024
x-mass
force-pushed
the
move-test-initializer
branch
from
2c082fd to
5d47b83
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.