Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crypto3 and libs/actor/zk updated #83 [SyncWith: proof-producer#83] #84

Merged
merged 2 commits into from
May 7, 2024
Merged

Crypto3 and libs/actor/zk updated #83 [SyncWith: proof-producer#83] #84

merged 2 commits into from
May 7, 2024

Conversation

ETatuzova
Copy link
Contributor

No description provided.

@ETatuzova ETatuzova linked an issue Mar 3, 2024 that may be closed by this pull request
Recursion-friendly changes #83
Closed
@ETatuzova ETatuzova requested a review from x-mass March 3, 2024 20:18
@ETatuzova
Copy link
Contributor Author

TODO: add JSON generation

x-mass
x-mass requested changes Mar 4, 2024
View reviewed changes
Copy link
Member

@x-mass x-mass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to run clang before commiting, otherwise check will not pass. It has a command to run in output log

bin/proof-generator/include/nil/proof-generator/arg_parser.hpp Outdated Show resolved Hide resolved
bin/proof-generator/include/nil/proof-generator/prover.hpp Outdated Show resolved Hide resolved
bin/proof-generator/src/arg_parser.cpp Outdated Show resolved Hide resolved
bin/proof-generator/src/main.cpp Outdated Show resolved Hide resolved
bin/proof-generator/src/main.cpp Outdated Show resolved Hide resolved
bin/proof-generator/include/nil/proof-generator/prover.hpp Outdated Show resolved Hide resolved
@ETatuzova ETatuzova changed the title Crypto3 and libs/actor/zk updated #83 Crypto3 and libs/actor/zk updated [SyncWith: crypto3-zk#321] #83 Apr 26, 2024
@ETatuzova ETatuzova force-pushed the 83-recursion-friendly branch from 913a3f0 to 67f839a Compare April 26, 2024 22:42
@nil-foundation-cicd-bot nil-foundation-cicd-bot bot mentioned this pull request Apr 26, 2024
Merged
@ETatuzova ETatuzova force-pushed the 83-recursion-friendly branch 7 times, most recently from bf4ddd9 to f26b149 Compare April 29, 2024 02:39
@x-mass x-mass force-pushed the 83-recursion-friendly branch 2 times, most recently from 08b0a46 to 1c30941 Compare April 30, 2024 16:19
@x-mass x-mass force-pushed the 83-recursion-friendly branch 2 times, most recently from 07e683c to ff34055 Compare April 30, 2024 22:29
@martun martun changed the title Crypto3 and libs/actor/zk updated [SyncWith: crypto3-zk#321] #83 Crypto3 and libs/actor/zk updated [SyncWith: proof-producer#83] #83 May 2, 2024
@nil-foundation-cicd-bot nil-foundation-cicd-bot bot mentioned this pull request May 2, 2024
Closed
@nil-foundation-cicd-bot
Copy link

Tests will be run in sync with other PRs containing [SyncWith NilFoundation/proof-producer#83] in title. You can find related PRs as linked with mentioned issue.

@martun martun force-pushed the 83-recursion-friendly branch 8 times, most recently from 426f3ba to 9806f05 Compare May 7, 2024 13:26
@martun martun force-pushed the 83-recursion-friendly branch from 9806f05 to c047882 Compare May 7, 2024 13:30
@martun martun changed the title Crypto3 and libs/actor/zk updated [SyncWith: proof-producer#83] #83 Crypto3 and libs/actor/zk updated #83 May 7, 2024
@martun martun force-pushed the 83-recursion-friendly branch from c047882 to 027465b Compare May 7, 2024 13:33
@martun martun changed the title Crypto3 and libs/actor/zk updated #83 Crypto3 and libs/actor/zk updated #83 [SyncWith: proof-producer#83] May 7, 2024
@martun martun force-pushed the 83-recursion-friendly branch from 027465b to 3d58c3d Compare May 7, 2024 14:01
@martun martun force-pushed the 83-recursion-friendly branch from 3d58c3d to 97b99ed Compare May 7, 2024 14:22
x-mass
x-mass approved these changes May 7, 2024
View reviewed changes
Copy link
Member

@x-mass x-mass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@martun martun merged commit ef8cd91 into master May 7, 2024
7 checks passed
@martun martun deleted the 83-recursion-friendly branch May 7, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@x-mass x-mass x-mass approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Recursion-friendly changes
3 participants
@ETatuzova @x-mass @martun