-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[enh] Make all process compatible with raw files #223
Conversation
@rcassani, is this PR ok to be merged ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Few things to be addressed
RawFileOut = bst_fullfile(newStudyPath, [rawBaseOut '.bst']); | ||
|
||
sFileIn = sDataRaw.F; | ||
sFileIn.channelflag = ones(size(final_dOD, 2), 1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrong field name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am quite confused. it seems that for raw data, the flag used is channelflag and not ChannelFlag :
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True, the one in F
is lowercase
Thanks a lot @rcassani :) |
My pleasure, have a nice weekend! |
This PAr aims at improving the way files are handled. The objective is to keep the type of the files. So if the input is raw, the output is raw. If the input is epoched data, so is the output.
Re-opening of #219