Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enh] Make all process compatible with raw files #223

Merged
merged 21 commits into from
Dec 9, 2023

Conversation

Edouard2laire
Copy link
Collaborator

This PAr aims at improving the way files are handled. The objective is to keep the type of the files. So if the input is raw, the output is raw. If the input is epoched data, so is the output.

Re-opening of #219

@Edouard2laire
Copy link
Collaborator Author

@rcassani, is this PR ok to be merged ?

Copy link
Contributor

@rcassani rcassani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Few things to be addressed

bst_plugin/preprocessing/process_nst_detrend.m Outdated Show resolved Hide resolved
bst_plugin/mbll/process_nst_dOD.m Outdated Show resolved Hide resolved
bst_plugin/mbll/process_nst_dOD.m Show resolved Hide resolved
RawFileOut = bst_fullfile(newStudyPath, [rawBaseOut '.bst']);

sFileIn = sDataRaw.F;
sFileIn.channelflag = ones(size(final_dOD, 2), 1);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong field name

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, the one in F is lowercase

bst_plugin/preprocessing/process_nst_motion_correction.m Outdated Show resolved Hide resolved
@Edouard2laire Edouard2laire merged commit 1fad744 into Nirstorm:master Dec 9, 2023
@Edouard2laire Edouard2laire deleted the raw_file branch December 9, 2023 00:33
@Edouard2laire
Copy link
Collaborator Author

Thanks a lot @rcassani :)

@rcassani
Copy link
Contributor

rcassani commented Dec 9, 2023

My pleasure, have a nice weekend!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants