gpm: fix static build #144909
Merged
gpm: fix static build #144909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Patch I developed to add support for static build into upstream build system do not apply cleanly on 1.20.7 release, so instead of backporting it, I decided to switch to git snapshot instead. It allowed to get rid of three other patches in nix expression, since they are applied upstream. => telmich/gpm#42 I requested proper release, but chance seems to be slim. => telmich/gpm#33
pkgs/servers/gpm/default.nix
Outdated
| @@ -51,13 +38,15 @@ stdenv.mkDerivation rec { | |||
| "--sysconfdir=/etc" | |||
| "--localstatedir=/var" | |||
| (if ncurses == null then "--without-curses" else "--with-curses") | |||
There was a problem hiding this comment.
Suggested change
| (if ncurses == null then "--without-curses" else "--with-curses") | |
| (if withNcurses then "--without-curses" else "--with-curses") |
Co-authored-by: Sandro <[email protected]>
Co-authored-by: Sandro <[email protected]>
|
I am okay with addition of |
alyssais
reviewed
Apr 30, 2022
Co-authored-by: Alyssa Ross <[email protected]>
Co-authored-by: Sandro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch I developed to add support for static build into upstream build system do
not apply cleanly on 1.20.7 release, so instead of backporting it, I decided to
switch to git snapshot instead. It allowed to get rid of three other patches
in nix expression, since they are applied upstream.
=> telmich/gpm#42
I requested proper release, but chance seems to be slim.
=> telmich/gpm#33
Motivation for this change
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)