Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vengi-tools: 0.0.17 -> 0.0.18 #159975

Merged
merged 2 commits into from
Feb 14, 2022
Merged

vengi-tools: 0.0.17 -> 0.0.18 #159975

merged 2 commits into from
Feb 14, 2022

Conversation

fgaz
Copy link
Member

@fgaz fgaz commented Feb 14, 2022

Motivation for this change
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

Please also take a look at #158116

@Artturin Artturin merged commit 736ba9a into NixOS:master Feb 14, 2022
@fgaz
Copy link
Member Author

fgaz commented Feb 14, 2022

@Artturin could you take a look at #158116 too? it's blocking the backport of this pr

@Artturin
Copy link
Member

can you include the backport of this in that pr

@fgaz
Copy link
Member Author

fgaz commented Feb 14, 2022

Done. Should I squash the revert or should the backport history mirror the one on master? For now I left it.

@fgaz fgaz deleted the vengi-tools/0.0.18 branch February 16, 2022 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants