Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

alttpr-opentracker: 1.8.2 -> 1.8.5 #209427

Merged
merged 1 commit into from
Feb 2, 2023
Merged

alttpr-opentracker: 1.8.2 -> 1.8.5 #209427

merged 1 commit into from
Feb 2, 2023

Conversation

JamieMagee
Copy link
Member

@JamieMagee JamieMagee commented Jan 7, 2023 •
edited
Loading

Description of changes

Related to #202572

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@JamieMagee
Copy link
Member Author

Result of nixpkgs-review pr 209427 run on x86_64-linux 1

1 package built:
  • alttpr-opentracker

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jan 7, 2023
@mdarocha mdarocha mentioned this pull request Jan 7, 2023
Closed
7 tasks
@JamieMagee JamieMagee requested a review from mdarocha January 7, 2023 21:22
@SuperSandro2000 SuperSandro2000 added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 23, 2023
@NickCao NickCao merged commit acce1a9 into NixOS:master Feb 2, 2023
@JamieMagee JamieMagee deleted the opentracker-1.8.5 branch September 3, 2023 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdarocha mdarocha mdarocha approved these changes

@IvarWithoutBones IvarWithoutBones Awaiting requested review from IvarWithoutBones

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JamieMagee @mdarocha @SuperSandro2000 @NickCao