vscode-extensions.ms-vsliveshare.vsliveshare: 1.0.5043 -> 1.0.5834 #220704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdarocha
force-pushed
the
vsliveshare-update
branch
from
dda4273 to
ff31e3f
Compare
mdarocha
force-pushed
the
vsliveshare-update
branch
from
ff31e3f to
836f16d
Compare
ofborg
bot
added
10.rebuild-darwin: 0
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/1952 |
|
Result of 1 package built:
|
superherointj
approved these changes
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Update to the latest version.
Since the underlying extension logic changed significantly, a lot of the previous patches no longer apply and were removed. From what I tested, the extension works fine.
Since this removes the extensions' dependency on native agents (microsoft/live-share#1272 (comment)), it removes the dependency on .NET Core 3.1 - and helps with #202572
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)