-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
haskell.compiler.ghcjs: fix build #228749
Conversation
Apply a patch from upstream `ghcjs/ghcjs/ghc-8.10` (not yet present in the obsidiansystems fork we follow) to fix a build failure caused by an emscripten update. As the patch itself modifies patches that are used during configuration (by `makePackages.sh`), it must be applied in the configured source derivation.
@ofborg build haskell.compiler.ghcjs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes in this PR look ok to me.
I looked at the upstream branch also and noted that a dozen or so commits were added.
The currently used fork of obsidiansystems can be updated with upstream, but that could cause things to break. And using the upstream branch directly will not be possible, as the commit 9fc935f2c3ba6 is necessary, based on my testing of ghcjs with reflex-dom project, (long time ago.)
So at the moment adding this patch looks better.
Why not contribute the necessary commits to ghcjs upstream? |
To be clear, the commit 9fc935f2c3ba6 is a revert commit (of e4cd4232a), the other commits on the fork have already been merged upstream. |
BTW, I tried compiling the latest upstream branch ghc-8.10 (commit b7711fbca7 ), and it did not work out of the box. Failed with compilation error in ghc. So there will be some work involved in getting it to work.
|
Fixes #208812
Apply a patch from upstream
ghcjs/ghcjs/ghc-8.10
(not yet present in the obsidiansystems fork we follow) to fix a build failure caused by an emscripten update.As the patch itself modifies patches that are used during configuration (by
makePackages.sh
), it must be applied in the configured source derivation.Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)