Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python310Packages.ytmusicapi: 1.1.1 -> 1.2.1 #251670

Merged
merged 1 commit into from
Aug 27, 2023

Conversation

dotlambda
Copy link
Member

Description of changes

Changelog: https://github.com/sigma67/ytmusicapi/releases/tag/1.2.1

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Aug 26, 2023
@fabaff
Copy link
Member

fabaff commented Aug 27, 2023

Result of nixpkgs-review pr 251670 run on x86_64-linux 1

2 packages failed to build:
  • mopidy-ytmusic
  • mopidy-ytmusic.dist
11 packages built:
  • libsForQt5.audiotube (plasma5Packages.audiotube)
  • mopidy-youtube
  • mopidy-youtube.dist
  • python310Packages.ytmusicapi
  • python310Packages.ytmusicapi.dist
  • python311Packages.ytmusicapi
  • python311Packages.ytmusicapi.dist
  • spotdl
  • spotdl.dist
  • ytmdl
  • ytmdl.dist
[...]
error: builder for '/nix/store/hchxrq51mlswpy13gh6lhfblymlck2xf-mopidy-ytmusic-0.3.8.drv' failed with exit code 1;
       last 10 log lines:
       > glibPreInstallPhase
       > installing
       > Executing pipInstallPhase
       > /build/mopidy_ytmusic-0.3.8/dist /build/mopidy_ytmusic-0.3.8
       > Processing ./mopidy_ytmusic-0.3.8-py3-none-any.whl
       > Requirement already satisfied: pytube<13.0.0,>=12.1.0 in /nix/store/0r85h3kp87wl25cqasb44qhl89i478qr-python3.10-pytube-12.1.2/lib/python3.10/site-packages (from mopidy-ytmusic==0.3.8) (12.1.2)
       > Requirement already satisfied: Mopidy<4,>=3 in /nix/store/3zklwlm3x178glc5apkfhw3nj4cx1hlg-mopidy-3.4.1/lib/python3.10/site-packages (from mopidy-ytmusic==0.3.8) (3.4.1)
       > ERROR: Could not find a version that satisfies the requirement ytmusicapi<0.30.0,>=0.22.0 (from mopidy-ytmusic) (from versions: none)
       > ERROR: No matching distribution found for ytmusicapi<0.30.0,>=0.22.0
       > 
       For full logs, run 'nix-store -l /nix/store/hchxrq51mlswpy13gh6lhfblymlck2xf-mopidy-ytmusic-0.3.8.drv'.

Known issue: OzymandiasTheGreat/mopidy-ytmusic#68

Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me.

@fabaff fabaff merged commit 45ab6b7 into NixOS:master Aug 27, 2023
@dotlambda dotlambda deleted the ytmusicapi-1.2.1 branch August 28, 2023 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants