Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

duff: 2014-07-03 -> 2024-02-16 #332234

Merged
merged 1 commit into from
Aug 5, 2024
Merged

duff: 2014-07-03 -> 2024-02-16 #332234

merged 1 commit into from
Aug 5, 2024

Conversation

posch
Copy link
Contributor

@posch posch commented Aug 4, 2024

This updates duff to the latest commit, removing links to a now hostile domain.

The old homepage link is blocked by ublock origin ("badware"). Due to the security risk, the change should be backported to 24.05.

Description of changes

See elmindreda/duff#14
and elmindreda/duff@c1baefa

Further, it seems the author's name changed, and now contains an Umlaut,
in elmindreda/duff@d7828fb
This requires an additional xgettest arg --from-code=utf-8 .

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

This updates duff to the latest commit, removing links to a now
hostile domain.
Copy link
Contributor

@LeSuisse LeSuisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upstream diff shows no major changes: elmindreda/duff@f26d483...c1baefa

Changes in this contribution look also good.

Result of nixpkgs-review pr 332234 run on x86_64-linux 1

1 package built:
  • duff

@LeSuisse LeSuisse merged commit a9f3956 into NixOS:master Aug 5, 2024
31 of 33 checks passed
Copy link
Contributor

github-actions bot commented Aug 5, 2024

Successfully created backport PR for release-24.05:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants