Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

telepathy-glib: fix gcc14 build #353945

Merged
merged 2 commits into from
Nov 7, 2024
Merged

telepathy-glib: fix gcc14 build #353945

merged 2 commits into from
Nov 7, 2024

Conversation

khaneliman
Copy link
Contributor

@khaneliman khaneliman commented Nov 6, 2024

Things done

ZHF: #352882
https://hydra.nixos.org/build/274108110/nixlog/6

Upstream has a commit that fixes our build issue, already.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@khaneliman khaneliman changed the title telepath-glib: fix gcc14 build telepathy-glib: fix gcc14 build Nov 6, 2024
@khaneliman khaneliman added the 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign label Nov 6, 2024
@khaneliman
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 353945


x86_64-linux

✅ 18 packages built:
  • libsForQt5.plasma-mobile
  • libsForQt5.telepathy
  • lomiri.history-service
  • lomiri.history-service.dev
  • lomiri.lomiri
  • lomiri.lomiri-session
  • lomiri.telephony-service
  • polari
  • telepathy-farstream
  • telepathy-gabble
  • telepathy-glib
  • telepathy-glib.dev
  • telepathy-haze
  • telepathy-idle
  • telepathy-logger
  • telepathy-mission-control
  • telepathy-mission-control.dev
  • telepathy-mission-control.lib

aarch64-linux

✅ 18 packages built:
  • libsForQt5.plasma-mobile
  • libsForQt5.telepathy
  • lomiri.history-service
  • lomiri.history-service.dev
  • lomiri.lomiri
  • lomiri.lomiri-session
  • lomiri.telephony-service
  • polari
  • telepathy-farstream
  • telepathy-gabble
  • telepathy-glib
  • telepathy-glib.dev
  • telepathy-haze
  • telepathy-idle
  • telepathy-logger
  • telepathy-mission-control
  • telepathy-mission-control.dev
  • telepathy-mission-control.lib

x86_64-darwin

❌ 2 packages failed to build:
  • telepathy-gabble
  • telepathy-haze
✅ 9 packages built:
  • libsForQt5.telepathy
  • telepathy-farstream
  • telepathy-glib
  • telepathy-glib.dev
  • telepathy-idle
  • telepathy-logger
  • telepathy-mission-control
  • telepathy-mission-control.dev
  • telepathy-mission-control.lib

aarch64-darwin

❌ 2 packages failed to build:
  • telepathy-gabble
  • telepathy-haze
✅ 9 packages built:
  • libsForQt5.telepathy
  • telepathy-farstream
  • telepathy-glib
  • telepathy-glib.dev
  • telepathy-idle
  • telepathy-logger
  • telepathy-mission-control
  • telepathy-mission-control.dev
  • telepathy-mission-control.lib

@wegank wegank merged commit 89149f8 into NixOS:master Nov 7, 2024
65 of 66 checks passed
@khaneliman khaneliman deleted the telepathy branch November 7, 2024 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants