Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vgm2x: 0-unstable-2024-06-18 -> 0-unstable-2024-11-17 #360009

Merged
merged 1 commit into from
Dec 8, 2024

Conversation

r-ryantm
Copy link
Contributor

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.

meta.description for vgm2x is: VGM file extraction tools

meta.homepage for vgm2x is: https://github.com/vampirefrog/vgm2x

Updates performed
  • Ran passthru.UpdateScript
To inspect upstream changes
Impact

Checks done


  • built on NixOS
  • The tests defined in passthru.tests, if any, passed
  • found 0-unstable-2024-11-17 in filename of file in /nix/store/vaqq8knkr96qvrp1arjakj8bfy0pvcay-vgm2x-0-unstable-2024-11-17

Rebuild report (if merged into master) (click to expand)
2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

vgm2x
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/vaqq8knkr96qvrp1arjakj8bfy0pvcay-vgm2x-0-unstable-2024-11-17 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A vgm2x https://github.com/r-ryantm/nixpkgs/archive/5157f42ddeecb87a60794145e7fd10b8d9a28c61.tar.gz

Or:

nix build github:r-ryantm/nixpkgs/5157f42ddeecb87a60794145e7fd10b8d9a28c61#vgm2x

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/vaqq8knkr96qvrp1arjakj8bfy0pvcay-vgm2x-0-unstable-2024-11-17
ls -la /nix/store/vaqq8knkr96qvrp1arjakj8bfy0pvcay-vgm2x-0-unstable-2024-11-17/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review


x86_64-linux

✅ 1 package built:
  • vgm2x

Maintainer pings

cc @OPNA2608 for testing.

Tip

As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.


Add a 👍 reaction to pull requests you find important.

@wolfgangwalther
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 360009


x86_64-darwin

❌ 1 package failed to build:
  • vgm2x

aarch64-darwin

❌ 1 package failed to build:
  • vgm2x

@wolfgangwalther
Copy link
Contributor

       >                         char rpath[PATH_MAX]; // FIXME: maybe allocate new string instead?
       >                                    ^
       > vgm2x.c:141:14: error: use of undeclared identifier 'PATH_MAX'
       >         char fmfile[PATH_MAX];
       >                     ^
       > vgm2x.c:288:22: error: use of undeclared identifier 'PATH_MAX'
       >                 char writable_path[PATH_MAX];
       >                                    ^
       > vgm2x.c:304:56: warning: format specifies type 'unsigned long' but the argument has type 'zip_uint64_t' (aka 'unsigned long long') [-Wformat]
       >                                         fprintf(stderr, "Could not allocate %lu bytes\n", st.size);
       >                                                                             ~~~           ^~~~~~~
       >                                                                             %llu
       > vgm2x.c:314:61: warning: format specifies type 'unsigned long' but the argument has type 'zip_uint64_t' (aka 'unsigned long long') [-Wformat]
       >                                         fprintf(stderr, "Could not read %lu bytes from zip\n", st.size);
       >                                                                         ~~~                    ^~~~~~~
       >                                                                         %llu
       > vgm2x.c:329:15: error: use of undeclared identifier 'PATH_MAX'
       >                                 char base[PATH_MAX];
       >                                           ^
       > vgm2x.c:353:13: error: use of undeclared identifier 'PATH_MAX'
       >                 char base[PATH_MAX];
       >                           ^
       > 2 warnings and 5 errors generated.
       > make: *** [Makefile:22: vgm2x.o] Error 1
       > make: *** Waiting for unfinished jobs....

@wolfgangwalther
Copy link
Contributor

Fails the same way on master.

@wolfgangwalther wolfgangwalther merged commit eed56f3 into NixOS:master Dec 8, 2024
37 of 38 checks passed
@OPNA2608
Copy link
Contributor

OPNA2608 commented Dec 8, 2024

vampirefrog/vgm2x#5

@r-ryantm r-ryantm deleted the auto-update/vgm2x branch December 9, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants