Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cplex: meta.mainProgram, desktop entry, fix oplide GUI, misc fixes #361105

Merged
merged 9 commits into from
Dec 15, 2024

Conversation

2xsaiko
Copy link
Contributor

@2xsaiko 2xsaiko commented Dec 2, 2024

  • Set meta.mainProgram
  • Fix phase hooks not running
  • Move doc and license files to share/doc and share/licenses
  • Install desktop entry for oplide
  • Fix file permissions (CPLEX installs everything as 755 by default)
  • Fix oplide not starting (this is prebuilt eclipse and needs to be wrapped appropriately)
  • Use autoPatchelfHook instead of manual patching

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Dec 2, 2024
@2xsaiko 2xsaiko force-pushed the push-zumumyllpvxq branch 6 times, most recently from adec398 to 0c8fab2 Compare December 5, 2024 23:34
@2xsaiko 2xsaiko marked this pull request as ready for review December 5, 2024 23:35
@2xsaiko 2xsaiko changed the title cplex: meta.mainProgram, desktop entry, misc fixes cplex: meta.mainProgram, desktop entry, fix oplide GUI, misc fixes Dec 5, 2024
@2xsaiko 2xsaiko requested a review from bfortz December 5, 2024 23:39
@bfortz
Copy link
Contributor

bfortz commented Dec 7, 2024

Great work, many thanks!

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 8, 2024
@wolfgangwalther wolfgangwalther merged commit 153abc8 into NixOS:master Dec 15, 2024
33 checks passed
@2xsaiko 2xsaiko added the backport release-24.11 Backport PR automatically label Dec 16, 2024
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Dec 16, 2024

Successfully created backport PR for release-24.11:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12.approvals: 1 This PR was reviewed and approved by one reputable person backport release-24.11 Backport PR automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants