-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
typora: fix #362036
typora: fix #362036
Conversation
7f8b5aa
to
19108f6
Compare
Also if you can backport this PR ? |
@liberodark Thanks a lot for looking into this. The spellcheck issue seems to be a permissions problem. Typora creates the folder In my system that folder is created without write permissions (only read and execute permissions for everybody). If you give it write permissions then Typora installs the dictionaries with no problem. |
@npulidomateo Thank you What do you think with this :
|
@liberodark Sorry just read this. I like your suggestion better than mine. Let's go with yours. |
@liberodark I checked again and Typora seems to create Thanks again and good night! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Successfully created backport PR for |
Fix partially : #362022
Launcher add possibility to set :
Only is missing spell support :
https://support.typora.io/Spellcheck/
https://github.com/typora/dictionaries
If you have idea for fix this ?
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.