lomiri.lomiri-music-app: init at 3.2.2 #364958
Open
+386
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
10.rebuild-darwin: 0
ofborg
bot
added
8.has: package (new)
OPNA2608
force-pushed
the
init/lomiri/lomiri-music-app
branch
from
75a857f to
f807862
Compare
github-actions
bot
added
6.topic: nixos
OPNA2608
force-pushed
the
init/lomiri/lomiri-music-app
branch
from
c44f03e to
7f323c6
Compare
OPNA2608
force-pushed
the
init/lomiri/lomiri-music-app
branch
from
db34306 to
7dcf738
Compare
OPNA2608
force-pushed
the
init/lomiri/lomiri-music-app
branch
from
389cdfc to
70ce0ea
Compare
|
@ofborg build lomiri.lomiri-music-app lomiri.lomiri-music-app.passthru.tests lomiri.lomiri-session lomiri.lomiri-session.passthru.tests lomiri.mediascanner2 lomiri.mediascanner2.passthru.tests |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/5044 |
OPNA2608
force-pushed
the
init/lomiri/lomiri-music-app
branch
from
70ce0ea to
8f661eb
Compare
OPNA2608
force-pushed
the
init/lomiri/lomiri-music-app
branch
3 times, most recently
from
9fb47ff to
6fe5017
Compare
mediascanner2 expects xdg-user-dirs to be set up properly, otherwise its g_get_user_special_dir() calls fail. Lomiri, by itself, doesn't seem to ensure this by default, so hack in a call of this.
OPNA2608
force-pushed
the
init/lomiri/lomiri-music-app
branch
from
6fe5017 to
fe7d0cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working towards #99090.
Lomiri Music App is the music-dedicated player app of the Lomiri DE.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.