mlterm: unbreak #370949
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,6 @@ | ||
| args@{ | ||
| stdenv, | ||
| gcc13Stdenv, | ||
| lib, | ||
| fetchFromGitHub, | ||
| pkg-config, | ||
|
|
@@ -98,6 +99,7 @@ let | |
| commaSepList = lib.concatStringsSep "," (builtins.attrNames (lib.filterAttrs (n: v: v) attrset)); | ||
| in | ||
| lib.withFeatureAs (commaSepList != "") featureName commaSepList; | ||
| stdenv = if args.stdenv.cc.isGNU then args.gcc13Stdenv else args.stdenv; | ||
| in | ||
|
There was a problem hiding this comment. It does not look like anything more elaborate than |
||
| stdenv.mkDerivation (finalAttrs: { | ||
| pname = "mlterm"; | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like this pattern TBH, I prefer using
stdenv'...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like it much but this is preferable better to the diff noise caused by replacing all references to
stdenvwithstdenv'IMHO.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't it just 1 line? It seems like it should either be this line or the
mkDerivationline.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stdenvis usually used in multiple places forstdenv.is*guards etc. I didn't check for this particular package; I just apply this pattern because it works everywhere.