Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdesk: 1.3.1 -> 1.3.6 #371408

Closed
wants to merge 2 commits into from
Closed

Conversation

yasinuslu
Copy link
Contributor

@yasinuslu yasinuslu commented Jan 6, 2025

Changelog

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ddogfoodd
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 371408

Copy link
Contributor

@ddogfoodd ddogfoodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs-review reports Nothing to be built.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 6, 2025
@nix-owners nix-owners bot requested review from ocfox and Leixb January 6, 2025 12:03
@ofborg ofborg bot added 2.status: merge conflict This PR has merge conflicts with the target branch and removed 2.status: merge conflict This PR has merge conflicts with the target branch labels Jan 6, 2025
@yasinuslu
Copy link
Contributor Author

@ddogfoodd which platform did you run the command on ?

@yasinuslu
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 371408


aarch64-linux

⏩ 1 package marked as broken and skipped:
  • rustdesk

@ddogfoodd
Copy link
Contributor

@ddogfoodd which platform did you run the command on ?

x86_64-linux

@yasinuslu
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 371408

@yasinuslu
Copy link
Contributor Author

@ddogfoodd thank you, I am also getting the same report now. I was able to build it in my first try on x86_64-linux (forgot to add --post-result in that run though)

@yasinuslu
Copy link
Contributor Author

yasinuslu commented Jan 6, 2025

I did a merge --squash on the latest master. Let's see how it will do now. I had some accidental changes before. I'm currently running two simultaneous nixpkgs-review pr 371408 --post-result command:

  • x86-64_linux
  • aarch64-linux

@yasinuslu
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 371408


x86_64-linux

❌ 1 package failed to build:
  • rustdesk

@yasinuslu
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 371408


aarch64-linux

@yasinuslu
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 371408


x86_64-linux

❌ 1 package failed to build:
  • rustdesk

@yasinuslu
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 371408


aarch64-linux

@yasinuslu yasinuslu marked this pull request as draft January 6, 2025 13:42
@yasinuslu
Copy link
Contributor Author

I think this update will be a little bit more involved than I initially thought. I converted this PR to draft mode, I'll publish it again when I get it working. Sorry about the inconvience

@ddogfoodd
Copy link
Contributor

@yasinuslu no worries, thank you for your effort!

@yzx9 yzx9 mentioned this pull request Jan 6, 2025
13 tasks
@ProxayFox
Copy link

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 371408


x86_64-linux

❌ 1 package failed to build:
  • rustdesk

@gepbird
Copy link
Contributor

gepbird commented Feb 11, 2025

Superseded by #380265

@gepbird gepbird closed this Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants