Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luminance-hdr: switch to openexr_3 #375839

Closed
wants to merge 1 commit into from

Conversation

autra
Copy link
Contributor

@autra autra commented Jan 22, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@autra
Copy link
Contributor Author

autra commented Jan 22, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 375839


x86_64-linux

❌ 1 package failed to build:
  • luminanceHDR

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1 10.rebuild-linux: 1-10 labels Jan 22, 2025
@nix-owners nix-owners bot requested a review from hrdinka January 22, 2025 14:01
@autra
Copy link
Contributor Author

autra commented Jan 22, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 375839


x86_64-linux

❌ 1 package failed to build:
  • luminanceHDR

@autra autra force-pushed the luminance-hdr-to-openexr3 branch from 9cf1f23 to 2e54a1a Compare January 22, 2025 14:41
@autra autra added the backport release-24.11 Backport PR automatically label Jan 22, 2025
@autra
Copy link
Contributor Author

autra commented Jan 22, 2025

upstream does not support openexr_3 yet: LuminanceHDR/LuminanceHDR#244. This doesn't look good, although there is a patch to try if we want to keep it alive a bit longer.

@hrdinka
Copy link
Contributor

hrdinka commented Jan 24, 2025

Hm, I don‘t mind trying the patch, but honestly – last release is 6 years old, think its dead Jim. There will just be more problems down the line.

Not sure how many users we have for it, I don’t want to take it away from them. If we do it, I am for keeping it at this only patch and ditching it as soon as more problems arise. I will give it a look, if it simply works with the patch, then lets use it, else I will remove it due not longer being maintained.

@autra
Copy link
Contributor Author

autra commented Jan 24, 2025

Hm, I don‘t mind trying the patch, but honestly – last release is 6 years old, think its dead Jim. There will just be more problems down the line.

I'll try the gentoo patch mentioned in the upstream issue, but I'm not a user of this package, so I don't mind removing it or making it as broken either.

@autra
Copy link
Contributor Author

autra commented Feb 8, 2025

In fact, it's not just this patch, gentoo maintains 10 (!) patches, and arch 4, and upstream has no active fork. It's more effort that I'm willing to put into a software I don't even use 😅

Closing this one. I'll mark it as broken when openexr2 is removed.

@autra autra closed this Feb 8, 2025
@autra autra deleted the luminance-hdr-to-openexr3 branch February 8, 2025 18:55
@hrdinka
Copy link
Contributor

hrdinka commented Feb 12, 2025

Fully agree. Many thanks for looking into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 backport release-24.11 Backport PR automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants