-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport release-24.11] incus: 6.8.0 -> 6.9.0 #376767
[Backport release-24.11] incus: 6.8.0 -> 6.9.0 #376767
Conversation
(cherry picked from commit 272fb5b)
Ahh, nice. The x86 test passed in ofborg. Built both x86 and aarch64 tests locally. Cherry-pick error is known, as I had to manually resolve the conflict in package.nix |
Something to do with lxc/incus#1547 subtly breaks read/write 9p mounts? As in, I get permission denied errors in the guest. Switching to virtiofs seems to sort it. This is probably only going to mess up people like me doing weird manual mounts - I assume the agent will handle it for most people. |
It looks like the db schema changed for 6.5, so using incus-lts (6.0.x) wouldn't be an easy option for anyone hit by this. I suppose we could add an explicit 6.8 package? But maybe not worth it unless anyone else complains :) |
Hmm, you could try reversing that patch to see if it fixes the issue. That was for qemu 9.2, which doesn't affect 24.11. I'll accept a PR to do so if it helps. Or we can revert this version and call non-LTS unsupported for the remainder of 24.11. I treat this package as a best effort on the stable release, but there's a point where it passes the amount of time I'm willing to spend to maintain. That's why LTS is the default :) |
Ah, I've fiddled with my VM to switch the mount to virtiofs and that's solved it for me. Probably not worth worrying about unless anyone else moans - we should be more or less half-way to 25.05 now anyway! (I think I ended up on non-LTS by accident - at one point I needed a feature not in the previous LTS, and forgot to switch back. This was the first time I noticed, by which time the schema upgrade has happened!) |
Yeah, the schema upgrades are a bit unfortunate. I'm not sure if there's a good way for us to protect users from the point of no return. :/ |
I can't think of a general solution that wouldn't involve throwing errors on upgrade to force the users to specifically consent to the schema update, and that doesn't feel like it's "the nixos way" :( The only thing that did occur to me is a way to request a minimum incus version, e.g. if you need a specific feature like I did. That could always select LTS where possible, and only non-LTS where necessary, eventually switching the user back to a later LTS when it had 'caught up.' But if I'm the only person doing weird things that may still be overkill :) |
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.