Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

serious-sans: drop #377216

Merged
merged 1 commit into from
Feb 8, 2025
Merged

Conversation

CobaltCause
Copy link
Contributor

The font has renamed itself to Serious Shanns, but also I don't really like these newer changes so I'm not interested in continuing to package this font.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 27, 2025
@niklaskorz
Copy link
Contributor

Please add an according note to nixos/doc/manual/release-notes/rl-2505.section.md. It's also possible to just drop yourself as maintainer and leaving it without any designated maintainers for now, waiting for someone else to pick it up, but seeing the upstream name changed, updating it would involve changing the package name, build script, repository... making it essentially a new package. So I'm impartial to removing the font package vs leaving it without a maintainer.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: changelog labels Jan 27, 2025
@CobaltCause
Copy link
Contributor Author

but seeing the upstream name changed, updating it would involve changing the package name, build script, repository... making it essentially a new package.

Yeah...

@github-actions github-actions bot added 10.rebuild-linux: 1-10 and removed 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 27, 2025
@wegank wegank added the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Feb 5, 2025
@donovanglover donovanglover merged commit 3127850 into NixOS:master Feb 8, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 12.approvals: 2 This PR was reviewed and approved by two reputable people
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants