Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clashtui: init at 0.2.3 #378672

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

clashtui: init at 0.2.3 #378672

wants to merge 2 commits into from
+54 −0

Conversation

lyranico
Copy link
Contributor

@lyranico lyranico commented Feb 1, 2025

base #372503

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

ethancedwards8
ethancedwards8 suggested changes Feb 2, 2025
View reviewed changes
pkgs/by-name/cl/clashtui/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/cl/clashtui/package.nix Show resolved Hide resolved
@lyranico lyranico force-pushed the clashtui branch 2 times, most recently from 1707904 to ed9d6d8 Compare February 2, 2025 14:55
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Feb 2, 2025
@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Feb 3, 2025
@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Feb 4, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1 10.rebuild-linux: 1-10 labels Feb 5, 2025
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethancedwards8 ethancedwards8 ethancedwards8 approved these changes

Assignees
No one assigned
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lyranico @ethancedwards8 @wegank