Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[staging-next] python312Packages.mocket: fix disabled test path #378788

Merged
merged 1 commit into from
Feb 2, 2025

Conversation

ofalvai
Copy link
Contributor

@ofalvai ofalvai commented Feb 2, 2025

┃        > Executing pytestCheckPhase
┃        > Disabled tests path glob "tests/main/test_redis.py" does not match any paths. Aborting
┃        For full logs, run 'nix log /nix/store/0f7n5b8ab25zhf4ld1r8ckkd4kmdm67i-python3.12-mocket-3.13.2.drv'.

I have a deeper refactor of Redis tests in progress at #357879, I'll investigate why these tests are disabled in the fist place.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@K900 K900 merged commit 1a5fbb3 into NixOS:staging-next Feb 2, 2025
17 of 20 checks passed
@github-actions github-actions bot added 10.rebuild-darwin: 11-100 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants