Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iwe: init at 0.0.17 #379477

Merged
merged 2 commits into from
Feb 11, 2025
Merged

iwe: init at 0.0.17 #379477

merged 2 commits into from
Feb 11, 2025

Conversation

phrmendes
Copy link
Contributor

@phrmendes phrmendes commented Feb 5, 2025 •
edited
Loading

iwe: Personal knowledge management system (editor plugin & command line utility)
https://iwe.md/

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Defelo
Defelo reviewed Feb 5, 2025
View reviewed changes
@phrmendes phrmendes force-pushed the master branch 2 times, most recently from 4338889 to f5bb7c7 Compare February 5, 2025 15:10
@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Feb 5, 2025
Defelo
Defelo reviewed Feb 5, 2025
View reviewed changes
Copy link
Member

@Defelo Defelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please split your changes into two commits:

  1. maintainers: add phrmendes
  2. iwe: init at 0.0.15

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Feb 5, 2025
@phrmendes phrmendes force-pushed the master branch 3 times, most recently from 34e4867 to 794973a Compare February 5, 2025 23:28
@github-actions github-actions bot added 10.rebuild-darwin: 1 10.rebuild-darwin: 1-10 10.rebuild-linux: 1 10.rebuild-linux: 1-10 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Feb 5, 2025
@Defelo
Copy link
Member

Defelo commented Feb 5, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 379477

Logs: https://github.com/Defelo/nixpkgs-review-gha/actions/runs/13168600663

Download packages from cache:
  • x86_64-linux 
    nix-store -r --add-root nixpkgs-pr-379477-x86_64-linux \
  --option binary-caches 'https://cache.nixos.org/ https://attic.defelo.de/nixpkgs' \
  --option trusted-public-keys '
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  nixpkgs:xeaAWa3crK09hMmFiygBeRmLq3hUjUShgaAwYVUEtw0=
  ' \
  /nix/store/ddisr3p5pwi82riz2yd0l3srj0692p8c-iwe-0.0.15
  • aarch64-linux 
    nix-store -r --add-root nixpkgs-pr-379477-aarch64-linux \
  --option binary-caches 'https://cache.nixos.org/ https://attic.defelo.de/nixpkgs' \
  --option trusted-public-keys '
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  nixpkgs:xeaAWa3crK09hMmFiygBeRmLq3hUjUShgaAwYVUEtw0=
  ' \
  /nix/store/bbljlcvl9agy9a9lva2pv6izlhg00ray-iwe-0.0.15
  • x86_64-darwin 
    nix-store -r --add-root nixpkgs-pr-379477-x86_64-darwin \
  --option binary-caches 'https://cache.nixos.org/ https://attic.defelo.de/nixpkgs' \
  --option trusted-public-keys '
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  nixpkgs:xeaAWa3crK09hMmFiygBeRmLq3hUjUShgaAwYVUEtw0=
  ' \
  /nix/store/mrd3zg93f6mn9y8kyc8v9i3mh7397jdm-iwe-0.0.15
  • aarch64-darwin 
    nix-store -r --add-root nixpkgs-pr-379477-aarch64-darwin \
  --option binary-caches 'https://cache.nixos.org/ https://attic.defelo.de/nixpkgs' \
  --option trusted-public-keys '
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  nixpkgs:xeaAWa3crK09hMmFiygBeRmLq3hUjUShgaAwYVUEtw0=
  ' \
  /nix/store/5aq9mzh0r1zpamrcmry6p056hv0c3b7v-iwe-0.0.15

x86_64-linux

✅ 1 package built:
  • iwe

aarch64-linux

✅ 1 package built:
  • iwe

x86_64-darwin

✅ 1 package built:
  • iwe

aarch64-darwin

✅ 1 package built:
  • iwe

@Defelo
Copy link
Member

Defelo commented Feb 5, 2025

@phrmendes It looks like $out/bin/ contains only the iwe binary for the cli, but it would also be useful to have the lsp server binary iwes for editor integration. Currently your src only contains the iwe crate, so I would suggest switching from fetchCrate to fetchFromGitHub to get the entire repository and then setting cargoBuildFlags to something like [ "--package=iwe" "--package=iwes" ] to only build these two crates.

@phrmendes phrmendes force-pushed the master branch 2 times, most recently from 81ec603 to 04abb11 Compare February 6, 2025 00:23
Defelo
Defelo reviewed Feb 6, 2025
View reviewed changes
@Defelo
Copy link
Member

Defelo commented Feb 6, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 379477

Logs: https://github.com/Defelo/nixpkgs-review-gha/actions/runs/13169496878

Download packages from cache:
  • x86_64-linux 
    nix-store -r --add-root nixpkgs-pr-379477-x86_64-linux \
  --option binary-caches 'https://cache.nixos.org/ https://attic.defelo.de/nixpkgs' \
  --option trusted-public-keys '
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  nixpkgs:xeaAWa3crK09hMmFiygBeRmLq3hUjUShgaAwYVUEtw0=
  ' \
  /nix/store/xxwny1xh3gjhx47g0lva6x1hjh80hg7l-iwe-0.0.15
  • aarch64-linux 
    nix-store -r --add-root nixpkgs-pr-379477-aarch64-linux \
  --option binary-caches 'https://cache.nixos.org/ https://attic.defelo.de/nixpkgs' \
  --option trusted-public-keys '
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  nixpkgs:xeaAWa3crK09hMmFiygBeRmLq3hUjUShgaAwYVUEtw0=
  ' \
  /nix/store/29vpmhia3dyksrsxyfkrmfiz28xfkm3n-iwe-0.0.15
  • x86_64-darwin 
    nix-store -r --add-root nixpkgs-pr-379477-x86_64-darwin \
  --option binary-caches 'https://cache.nixos.org/ https://attic.defelo.de/nixpkgs' \
  --option trusted-public-keys '
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  nixpkgs:xeaAWa3crK09hMmFiygBeRmLq3hUjUShgaAwYVUEtw0=
  ' \
  /nix/store/i9lygd65kvww317mh8z5b5i9x5fjq3qw-iwe-0.0.15
  • aarch64-darwin 
    nix-store -r --add-root nixpkgs-pr-379477-aarch64-darwin \
  --option binary-caches 'https://cache.nixos.org/ https://attic.defelo.de/nixpkgs' \
  --option trusted-public-keys '
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  nixpkgs:xeaAWa3crK09hMmFiygBeRmLq3hUjUShgaAwYVUEtw0=
  ' \
  /nix/store/yimhs79jav63sdkqm4ph0a218fl9mskb-iwe-0.0.15

x86_64-linux

✅ 1 package built:
  • iwe

aarch64-linux

✅ 1 package built:
  • iwe

x86_64-darwin

✅ 1 package built:
  • iwe

aarch64-darwin

✅ 1 package built:
  • iwe

Defelo
Defelo approved these changes Feb 6, 2025
View reviewed changes
Copy link
Member

@Defelo Defelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested on x86_64-linux

@Defelo Defelo added 8.has: package (new) This PR adds a new package 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Feb 6, 2025
@phrmendes
Copy link
Contributor Author

The package has released a new version. @Defelo can I update this PR?

@Defelo
Copy link
Member

Defelo commented Feb 7, 2025

Sure

@phrmendes phrmendes changed the title iwe: init at 0.0.15 iwe: init at 0.0.16 Feb 8, 2025
@Defelo
Copy link
Member

Defelo commented Feb 8, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 379477

Logs: https://github.com/Defelo/nixpkgs-review-gha/actions/runs/13217287034

x86_64-linux

❌ 1 package failed to build:
  • iwe

aarch64-linux

❌ 1 package failed to build:
  • iwe

x86_64-darwin

❌ 1 package failed to build:
  • iwe

aarch64-darwin

❌ 1 package failed to build:
  • iwe

@Defelo
Copy link
Member

Defelo commented Feb 8, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 379477

Logs: https://github.com/Defelo/nixpkgs-review-gha/actions/runs/13217461546

Download packages from cache:
  • x86_64-linux 
    nix-store -r --add-root nixpkgs-pr-379477-x86_64-linux \
  --option binary-caches 'https://cache.nixos.org/ https://attic.defelo.de/nixpkgs' \
  --option trusted-public-keys '
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  nixpkgs:xeaAWa3crK09hMmFiygBeRmLq3hUjUShgaAwYVUEtw0=
  ' \
  /nix/store/nw5s7bxm568af7pxh9rzgwxbap8fw3q7-iwe-0.0.16
  • aarch64-linux 
    nix-store -r --add-root nixpkgs-pr-379477-aarch64-linux \
  --option binary-caches 'https://cache.nixos.org/ https://attic.defelo.de/nixpkgs' \
  --option trusted-public-keys '
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  nixpkgs:xeaAWa3crK09hMmFiygBeRmLq3hUjUShgaAwYVUEtw0=
  ' \
  /nix/store/mp4nd1ybbhfc1sv6f2qkc7nvx75syal6-iwe-0.0.16
  • x86_64-darwin 
    nix-store -r --add-root nixpkgs-pr-379477-x86_64-darwin \
  --option binary-caches 'https://cache.nixos.org/ https://attic.defelo.de/nixpkgs' \
  --option trusted-public-keys '
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  nixpkgs:xeaAWa3crK09hMmFiygBeRmLq3hUjUShgaAwYVUEtw0=
  ' \
  /nix/store/xpa18dnwzgshyjr5s9y20xn0k87cs69j-iwe-0.0.16
  • aarch64-darwin 
    nix-store -r --add-root nixpkgs-pr-379477-aarch64-darwin \
  --option binary-caches 'https://cache.nixos.org/ https://attic.defelo.de/nixpkgs' \
  --option trusted-public-keys '
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  nixpkgs:xeaAWa3crK09hMmFiygBeRmLq3hUjUShgaAwYVUEtw0=
  ' \
  /nix/store/lcqrwzfqs681rj87012xcb9x16rd304z-iwe-0.0.16

x86_64-linux

✅ 1 package built:
  • iwe

aarch64-linux

✅ 1 package built:
  • iwe

x86_64-darwin

✅ 1 package built:
  • iwe

aarch64-darwin

✅ 1 package built:
  • iwe

@donovanglover donovanglover mentioned this pull request Feb 10, 2025
Closed
13 tasks
@phrmendes phrmendes changed the title iwe: init at 0.0.16 iwe: init at 0.0.17 Feb 10, 2025
@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Feb 10, 2025
@phrmendes phrmendes requested a review from Defelo February 11, 2025 02:49
@Aleksanaa Aleksanaa merged commit e03305d into NixOS:master Feb 11, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aleksanaa Aleksanaa Aleksanaa approved these changes

@Defelo Defelo Awaiting requested review from Defelo

Assignees
No one assigned
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@phrmendes @Defelo @Aleksanaa @wegank