Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shark: fix build with boost187 #379790

Merged
merged 1 commit into from
Feb 11, 2025
Merged

Conversation

tobim
Copy link
Contributor

@tobim tobim commented Feb 6, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Contributor

@daspk04 daspk04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tobim !

Thanks for the fix.

The official otb package seems to be using boost version 1.86.0, given that shark will have no official release and more likely to be used only while building otb (not sure if anyone would be using shark package), will it make sense to fix the boost version to 1.86.0 ?

@tobim
Copy link
Contributor Author

tobim commented Feb 7, 2025

will it make sense to fix the boost version to 1.86.0 ?

I believe pinning to a specific version of a library that does not explicitly support multi-versioning at runtime it not something that should be done in libraries, no matter how obscure they are.

We can fix otb in another PR, I believe support for current boost has already been merged upstream, but swig is giving me trouble.

@daspk04
Copy link
Contributor

daspk04 commented Feb 8, 2025

Thanks @tobim !

@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Feb 9, 2025
@Aleksanaa Aleksanaa merged commit 6591a62 into NixOS:master Feb 11, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants