Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glib-networking: remove obsolete p11-kit input #380365

Merged
merged 1 commit into from
Feb 8, 2025

Conversation

alyssais
Copy link
Member

@alyssais alyssais commented Feb 8, 2025

glib-networking hasn't had a direct dependency on p11-kit since upstream commit 4d6caa0 ("Remove the PKCS#11 backend"), first included in glib-networking 2.59.1.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

glib-networking hasn't had a direct dependency on p11-kit since
upstream commit 4d6caa0 ("Remove the PKCS#11 backend"), first included
in glib-networking 2.59.1.
Copy link
Member

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@jtojnar
Copy link
Member

jtojnar commented Feb 8, 2025

Might be better to go to staging to avoid unnecessary rebuild of webkitgtk on master.

We will want to merge along with #380390

@bobby285271 bobby285271 mentioned this pull request Feb 8, 2025
13 tasks
@jtojnar jtojnar merged commit b9a5b64 into NixOS:master Feb 8, 2025
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants