Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.{bpycv,zcs,boxx,fn}: remove #380443

Merged
merged 4 commits into from
Feb 15, 2025

Conversation

ruro
Copy link
Contributor

@ruro ruro commented Feb 8, 2025

bpycv package and its dependencies (zcs, boxx and fn) were broken for quite some time (for at least 7 months, possibly much longer) and nobody seemed to notice. Additionally, bpycv seems to be incompatible with Blender version 4 or later.

See #379872 and #380403 for more context.

Closes #379872.

Things done

  • removed bpycv
  • removed zcs
  • removed boxx
  • removed fn

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

ruro added a commit to ruro/nixpkgs that referenced this pull request Feb 8, 2025
The bpycv package is incompatible with blender version 4 or later. It
seems that neither upstream author nor the nixpkgs maintainer are
currently interested in updating/maintaining this package.

See:
- NixOS#379872
- DIYer22/bpycv#51
- NixOS#380403
- NixOS#380443
@ruro ruro force-pushed the remove-bpycv-and-friends branch from efaaba2 to 51c4d4a Compare February 8, 2025 20:07
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Feb 8, 2025
ruro added a commit to ruro/nixpkgs that referenced this pull request Feb 8, 2025
The bpycv package is incompatible with blender version 4 or later. It
seems that neither upstream author nor the nixpkgs maintainer are
currently interested in updating/maintaining this package.

See:
- NixOS#379872
- DIYer22/bpycv#51
- NixOS#380403
- NixOS#380443
@ruro ruro force-pushed the remove-bpycv-and-friends branch from 51c4d4a to e93f0f5 Compare February 8, 2025 20:26
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation This PR adds or changes documentation 10.rebuild-linux: 1-10 and removed 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Feb 8, 2025
@ruro ruro marked this pull request as ready for review February 9, 2025 16:52
@ruro
Copy link
Contributor Author

ruro commented Feb 9, 2025

@lucasew removing bpycv and related leaf packages as discussed. Please, take a look.

@nix-owners nix-owners bot requested a review from natsukium February 9, 2025 16:54
@lucasew
Copy link
Contributor

lucasew commented Feb 9, 2025

We, at $WORK, initially used this bpycv for a internal project. Nix helped us deal with patching a object leakage bug which has been upstreamed and this nix nature of requiring one to specify everything then become more of a hassle than a advantage, so we moved to Conda.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Feb 9, 2025
@ruro ruro mentioned this pull request Feb 14, 2025
13 tasks
ruro added 4 commits February 14, 2025 19:25
The bpycv package is incompatible with blender version 4 or later. It
seems that neither upstream author nor the nixpkgs maintainer are
currently interested in updating/maintaining this package.

See:
- NixOS#379872
- DIYer22/bpycv#51
- NixOS#380403
- NixOS#380443
This package was only used as a dependency of bpycv which was removed in
the previous commit.
This package was only used as a dependency of bpycv which was removed in
the previous commit.
This package was only used as a dependency of bpycv which was removed in
the previous commit.
@ruro ruro force-pushed the remove-bpycv-and-friends branch from e93f0f5 to 1320c06 Compare February 14, 2025 16:29
@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Feb 14, 2025
@lucasew
Copy link
Contributor

lucasew commented Feb 15, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 380443


x86_64-linux

⏩ 2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test

@prusnak prusnak merged commit 1a1da0c into NixOS:master Feb 15, 2025
27 of 28 checks passed
NotAShelf pushed a commit to feel-co/fp that referenced this pull request Feb 17, 2025
The bpycv package is incompatible with blender version 4 or later. It
seems that neither upstream author nor the nixpkgs maintainer are
currently interested in updating/maintaining this package.

See:
- NixOS#379872
- DIYer22/bpycv#51
- NixOS#380403
- NixOS#380443
eclairevoyant pushed a commit to feel-co/fp that referenced this pull request Feb 17, 2025
The bpycv package is incompatible with blender version 4 or later. It
seems that neither upstream author nor the nixpkgs maintainer are
currently interested in updating/maintaining this package.

See:
- NixOS#379872
- DIYer22/bpycv#51
- NixOS#380403
- NixOS#380443
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python 8.has: changelog 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failure: python3Packages.boxx
4 participants