Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mullvad-browser: 14.0.4 -> 14.0.5 #380471

Merged
merged 1 commit into from
Feb 9, 2025

Conversation

felschr
Copy link
Member

@felschr felschr commented Feb 8, 2025

https://github.com/mullvad/mullvad-browser/releases/tag/14.0.5

This version includes important security updates to Firefox.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@felschr felschr added 1.severity: security Issues which raise a security issue, or PRs that fix one backport release-24.11 Backport PR automatically labels Feb 8, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1 10.rebuild-linux: 1-10 labels Feb 8, 2025
@nix-owners nix-owners bot requested review from SigmaSquadron and panicgh February 8, 2025 21:50
@ddogfoodd
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 380471


x86_64-linux

❌ 1 package failed to build:
  • mullvad-browser

Copy link
Contributor

@ddogfoodd ddogfoodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs-review pr 380471 failed for me:

error: builder for '/nix/store/jfzcghlq174xlxj47bac3z0b49la664c-mullvad-browser-14.0.5.drv' failed with exit code 1;
       last 25 log lines:
       > setting RPATH to: /nix/store/khwc6k23mmi2b5zl56s612wnknkfg013-mullvad-browser-14.0.5/share/mullvad-browser
       > searching for dependencies of /nix/store/khwc6k23mmi2b5zl56s612wnknkfg013-mullvad-browser-14.0.5/share/mullvad-browser/libmozgtk.so
       >     libgtk-3.so.0 -> found: /nix/store/qbaqmm44k3dlrklaz9bml687jkqwsd6j-gtk+3-3.24.43/lib
       >     libgdk-3.so.0 -> found: /nix/store/qbaqmm44k3dlrklaz9bml687jkqwsd6j-gtk+3-3.24.43/lib
       > setting RPATH to: /nix/store/qbaqmm44k3dlrklaz9bml687jkqwsd6j-gtk+3-3.24.43/lib
       > searching for dependencies of /nix/store/khwc6k23mmi2b5zl56s612wnknkfg013-mullvad-browser-14.0.5/share/mullvad-browser/liblgpllibs.so
       >     libstdc++.so.6 -> found: /nix/store/khwc6k23mmi2b5zl56s612wnknkfg013-mullvad-browser-14.0.5/share/mullvad-browser/libstdc++
       >     libgcc_s.so.1 -> found: /nix/store/qjg34af79vcz9k2x386wjg6pk905cs42-gcc-14-20241116-libgcc/lib
       > setting RPATH to: /nix/store/khwc6k23mmi2b5zl56s612wnknkfg013-mullvad-browser-14.0.5/share/mullvad-browser/libstdc++:/nix/store/qjg34af79vcz9k2x386wjg6pk905cs42-gcc-14-20241116-libgcc/lib
       > searching for dependencies of /nix/store/khwc6k23mmi2b5zl56s612wnknkfg013-mullvad-browser-14.0.5/share/mullvad-browser/libstdc++/libstdc++.so.6.0.28
       >     libgcc_s.so.1 -> found: /nix/store/qjg34af79vcz9k2x386wjg6pk905cs42-gcc-14-20241116-libgcc/lib
       > setting RPATH to: /nix/store/qjg34af79vcz9k2x386wjg6pk905cs42-gcc-14-20241116-libgcc/lib
       > searching for dependencies of /nix/store/khwc6k23mmi2b5zl56s612wnknkfg013-mullvad-browser-14.0.5/share/mullvad-browser/libstdc++/libstdc++.so.6
       >     libgcc_s.so.1 -> found: /nix/store/qjg34af79vcz9k2x386wjg6pk905cs42-gcc-14-20241116-libgcc/lib
       > setting RPATH to: /nix/store/qjg34af79vcz9k2x386wjg6pk905cs42-gcc-14-20241116-libgcc/lib
       > auto-patchelf: 0 dependencies could not be satisfied
       > rewriting symlink /nix/store/khwc6k23mmi2b5zl56s612wnknkfg013-mullvad-browser-14.0.5/share/icons/hicolor/128x128/apps/mullvad-browser.png to be relative to /nix/store/khwc6k23mmi2b5zl56s612wnknkfg013-mullvad-browser-14.0.5
       > rewriting symlink /nix/store/khwc6k23mmi2b5zl56s612wnknkfg013-mullvad-browser-14.0.5/share/icons/hicolor/48x48/apps/mullvad-browser.png to be relative to /nix/store/khwc6k23mmi2b5zl56s612wnknkfg013-mullvad-browser-14.0.5
       > rewriting symlink /nix/store/khwc6k23mmi2b5zl56s612wnknkfg013-mullvad-browser-14.0.5/share/icons/hicolor/32x32/apps/mullvad-browser.png to be relative to /nix/store/khwc6k23mmi2b5zl56s612wnknkfg013-mullvad-browser-14.0.5
       > rewriting symlink /nix/store/khwc6k23mmi2b5zl56s612wnknkfg013-mullvad-browser-14.0.5/share/icons/hicolor/16x16/apps/mullvad-browser.png to be relative to /nix/store/khwc6k23mmi2b5zl56s612wnknkfg013-mullvad-browser-14.0.5
       > rewriting symlink /nix/store/khwc6k23mmi2b5zl56s612wnknkfg013-mullvad-browser-14.0.5/share/icons/hicolor/64x64/apps/mullvad-browser.png to be relative to /nix/store/khwc6k23mmi2b5zl56s612wnknkfg013-mullvad-browser-14.0.5
       > the symlink /nix/store/khwc6k23mmi2b5zl56s612wnknkfg013-mullvad-browser-14.0.5/share/doc/mullvad-browser is broken, it points to /nix/store/khwc6k23mmi2b5zl56s612wnknkfg013-mullvad-browser-14.0.5/share/mullvad-browser/Data/Docs (which is missing)
       > rewriting symlink /nix/store/khwc6k23mmi2b5zl56s612wnknkfg013-mullvad-browser-14.0.5/share/doc/mullvad-browser to be relative to /nix/store/khwc6k23mmi2b5zl56s612wnknkfg013-mullvad-browser-14.0.5
       > ERROR: noBrokenSymlinks: the symlink /nix/store/khwc6k23mmi2b5zl56s612wnknkfg013-mullvad-browser-14.0.5/share/doc/mullvad-browser points to a missing target /nix/store/khwc6k23mmi2b5zl56s612wnknkfg013-mullvad-browser-14.0.5/share/mullvad-browser/Data/Docs
       > ERROR: noBrokenSymlinks: found 1 dangling symlinks and 0 reflexive symlinks
       For full logs, run 'nix log /nix/store/jfzcghlq174xlxj47bac3z0b49la664c-mullvad-browser-14.0.5.drv'.
error: 1 dependencies of derivation '/nix/store/ah4rn2wnjyv06rgf391qbqp3332190a0-review-shell.drv' failed to build

Link to currently reviewing PR:
https://github.com/NixOS/nixpkgs/pull/380471

--------- Report for 'x86_64-linux' ---------
1 package failed to build:
mullvad-browser

@felschr felschr force-pushed the mullvad-browser-updates branch from 2f1e100 to 99f966f Compare February 8, 2025 23:55
@ddogfoodd
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 380471


x86_64-linux

✅ 1 package built:
  • mullvad-browser

@felschr felschr merged commit b23e739 into NixOS:master Feb 9, 2025
46 checks passed
@felschr felschr deleted the mullvad-browser-updates branch February 9, 2025 12:53
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Feb 9, 2025

Successfully created backport PR for release-24.11:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 backport release-24.11 Backport PR automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants